feat(toHaveAttribute): support asymmetric matchers for value

[revathskumar]

Fixes #91

Sample Error message

What:

toHaveAttribute value will accept asymmetric matchers

Why:

asymmetric matchers are handy when we want to do partial matching

How:

Using the method equals in expect/JasmineUtils

Checklist:

• Documentation
• Tests
• Updated Type Definitions
• Ready to be merged
• Added myself to contributors table

[revathskumar]

@gnapse Working on updating the docs.

[revathskumar]

Updated the documentation

[gnapse]

This is looking good! Just a comment to fix a small typo, and let's take a bit more time to check the types situation.

[revathskumar]

@gnapse ping

[gnapse]

@revathskumar I'm ready to merge. Can you fix the conflict in the README? You should be able to rebase this on top of master, and when faced with the conflict locally, run npm run precommit, which should rewrite this part of the README. Then git add and git rebase --continue. I'd do it but I'd need to add your repo as a new remote in git and download your branch. I can try later, but if can get to it first, that'd be great.

And thanks again for your contribution!

[revathskumar]

@gnapse I have rebased and pushed.
But seems like travis is not triggered.

[gnapse]

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[bopfer]

I think the typings are breaking things. I get this after upgrading:

./node_modules/jest-dom/extend-expect.d.ts:11:5 - error TS2717: Subsequent property declarations must have the same type.  Property 'not' must be of type 'InverseAsymmetricMatchers', but here has type 'InverseStringAsymmetricMatchers'.

11     not: InverseStringAsymmetricMatchers
       ~~~

./node_modules/jest-dom/extend-expect.d.ts:16:7 - error TS2713: Cannot access 'Expect.stringContaining' because 'Expect' is a type, but not a namespace. Did you mean to retrieve the type of the property 'stringContaining' in 'Expect' with 'Expect["stringContaining"]'?

16     | Expect.stringContaining
         ~~~~~~~~~~~~~~~~~~~~~~~

./node_modules/jest-dom/extend-expect.d.ts:17:7 - error TS2713: Cannot access 'Expect.stringMatching' because 'Expect' is a type, but not a namespace. Did you mean to retrieve the type of the property 'stringMatching' in 'Expect' with 'Expect["stringMatching"]'?

17     | Expect.stringMatching
         ~~~~~~~~~~~~~~~~~~~~~

./node_modules/jest-dom/extend-expect.d.ts:18:7 - error TS2713: Cannot access 'Expect.any' because 'Expect' is a type, but not a namespace. Did you mean to retrieve the type of the property 'any' in 'Expect' with 'Expect["any"]'?

18     | Expect.any
         ~~~~~~~~~~

./node_modules/jest-dom/extend-expect.d.ts:19:7 - error TS2713: Cannot access 'Expect.anything' because 'Expect' is a type, but not a namespace. Did you mean to retrieve the type of the property 'anything' in 'Expect' with 'Expect["anything"]'?

19     | Expect.anything
         ~~~~~~~~~~~~~~~

./node_modules/jest-dom/extend-expect.d.ts:20:7 - error TS2713: Cannot access 'Expect.not' because 'Expect' is a type, but not a namespace. Did you mean to retrieve the type of the property 'not' in 'Expect' with 'Expect["not"]'?

20     | Expect.not
         ~~~~~~~~~~

[mdgozza]

Fix for type regression: #101

[SimenB]

equals is injected into custom matchers as this.equals: https://jestjs.io/docs/en/expect#thisequalsa-b, it'd be great if you could use that instead

We provide no guarantees that 'expect/build/jasmineUtils' is an import that will not break at any time

[gnapse]

Thanks for the tip @SimenB!

@revathskumar can you take that since you originally authored this change?

[revathskumar]

@gnapse Sure. will look into it.

[revathskumar]

@gnapse @SimenB please review #103