Fix options types for extend API #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
Aug 14, 2020
|
oof sorry @jrolfs I forgot to merge this the other day and just merged a conflicting PR 😬 I think it might have fixed the same underlying issue though, if you just want to revert the typedef changes and ensure the tests still work? |
jrolfs
force-pushed
the
fix/options-types
branch
from
857bac4 to
9409ea8
Compare
|
Haha, sigh, yeah I got one-upped in the TypeScript department here 😛. I just cherry-picked this into the Playwright fork... I think these tests are still worth merging? |
patrickhulce
approved these changes
Aug 18, 2020
Most def 👍 thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally a PR from me that's intentional 😅
This fixes the type definitions for the
optionsparameter for the queries when using theextendentry point.Some of the queries accept a
selectoroption and some don't so I just made sure that the derivedIScopedQueryMethodspulls theoptionstype from the respective definition inIQueryMethods.