Skip to content

Fix: foreign keys order #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2017
Merged

Conversation

dsavina
Copy link
Contributor

@dsavina dsavina commented Jun 26, 2017

When walking through junction table, the variable $currentTable was not updated. Therefore, in case of successive junction tables, the order of the foreign keys as not well ensured.

@coveralls
Copy link

coveralls commented Jun 26, 2017

Coverage Status

Coverage increased (+0.002%) to 99.692% when pulling 35540bf on dsavina:fix/path-order into d543c34 on thecodingmachine:1.1.

@moufmouf
Copy link
Member

Damn'it! You are right!
Care to write a unit test to test this? (I'm merging meanwhile as this is clearly a bug)

@moufmouf moufmouf merged commit 7216850 into thecodingmachine:1.1 Jun 26, 2017
@dsavina dsavina mentioned this pull request Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants