Update implementations #7335

kumaryash90 · 2025-06-13T12:03:51Z

PR-Codex overview

This PR focuses on updating the MarketplaceV3 addresses in the ZKSYNC_IMPLEMENTATIONS and ZKSYNC_WETH records, ensuring the correct Ethereum addresses are associated with the MarketplaceV3 key.

Detailed summary

Updated MarketplaceV3 address for [324] from 0x88e7F2bEf0a23073b7Cc2c79D307Dbd9138Fa79c to 0xFD5663B3Ed316aEB79c9b5c4A242172273cA3395.
Updated MarketplaceV3 address for [2741] from 0x4b14569c7B79DBe686Ac3Ba5996131E7EDaB7a93 to 0x9Fdf34f552cdA8E2B0cD64e2EddcB732a5Ff8455.
Added new MarketplaceV3 entry for [531050104] with address 0x292c324920d4120F928dA6f04548442fa10B8B0f.
Added new MarketplaceV3 entry for [50104] with address 0x292c324920d4120F928dA6f04548442fa10B8B0f.
Added new WETH entry for [531050104] with address 0x9B7EA63EF5062661570afe548e3AD691D5652527.
Added new WETH entry for [50104] with address 0x2b1A859dE6A55c553520D7780Bc5805712B128F9.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

New Features
- Added support for MarketplaceV3 contract on two additional networks.
- Updated MarketplaceV3 contract addresses on existing networks for improved compatibility.
- Introduced new WETH token support for the added networks.

changeset-bot · 2025-06-13T12:03:54Z

⚠️ No Changeset found

Latest commit: 64ee04c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-06-13T12:03:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2025 1:58pm
login	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2025 1:58pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2025 1:58pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2025 1:58pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 13, 2025 1:58pm

graphite-app · 2025-06-13T12:03:57Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

coderabbitai · 2025-06-13T12:03:59Z

Walkthrough

The ZKSYNC_IMPLEMENTATIONS mapping was updated with new MarketplaceV3 contract addresses for network IDs 324 and 2741. Additionally, two new network IDs, 531050104 and 50104, were added with the same MarketplaceV3 address. Corresponding entries for these new network IDs were also added to the ZKSYNC_WETH mapping.

Changes

File	Change Summary
packages/thirdweb/src/contract/deployment/zksync/implementations.ts	Updated MarketplaceV3 contract addresses for network IDs 324 and 2741; added MarketplaceV3 and WETH addresses for network IDs 531050104 and 50104.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ZKSYNC_IMPLEMENTATIONS

    Client->>ZKSYNC_IMPLEMENTATIONS: Query MarketplaceV3 address for network IDs 324, 2741, 531050104, or 50104
    ZKSYNC_IMPLEMENTATIONS-->>Client: Return corresponding MarketplaceV3 contract address

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90426a2 and 64ee04c.

📒 Files selected for processing (1)

packages/thirdweb/src/contract/deployment/zksync/implementations.ts (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/thirdweb/src/contract/deployment/zksync/implementations.ts

⏰ Context from checks skipped due to timeout of 90000ms (6)

GitHub Check: Size
GitHub Check: E2E Tests (pnpm, vite)
GitHub Check: Build Packages
GitHub Check: Unit Tests
GitHub Check: Lint Packages
GitHub Check: Analyze (javascript)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-06-13T12:09:41Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	62.44 KB (0%)	1.3 s (0%)	183 ms (+140.76% 🔺)	1.5 s
thirdweb (cjs)	350.62 KB (0%)	7.1 s (0%)	650 ms (+12.32% 🔺)	7.7 s
thirdweb (minimal + tree-shaking)	5.7 KB (0%)	114 ms (0%)	70 ms (+1576.89% 🔺)	184 ms
thirdweb/chains (tree-shaking)	531 B (0%)	11 ms (0%)	42 ms (+2367.85% 🔺)	53 ms
thirdweb/react (minimal + tree-shaking)	19.59 KB (0%)	392 ms (0%)	93 ms (+730.44% 🔺)	485 ms

codecov · 2025-06-13T12:10:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (680b8cd) to head (64ee04c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7335   +/-   ##
=======================================
  Coverage   55.57%   55.58%           
=======================================
  Files         909      909           
  Lines       58675    58683    +8     
  Branches     4160     4158    -2     
=======================================
+ Hits        32609    32617    +8     
  Misses      25959    25959           
  Partials      107      107

Flag	Coverage Δ
packages	`55.58% <100.00%> (+<0.01%)`	⬆️

Files with missing lines	Coverage Δ
.../src/contract/deployment/zksync/implementations.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kumaryash90 · 2025-06-13T13:40:59Z

Merge activity

Jun 13, 1:40 PM UTC: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Jun 13, 1:49 PM UTC: kumaryash90 added this pull request to the Graphite merge queue.
Jun 13, 1:59 PM UTC: Merged by the Graphite merge queue.

--- ## PR-Codex overview This PR focuses on updating the `MarketplaceV3` addresses in the `ZKSYNC_IMPLEMENTATIONS` and `ZKSYNC_WETH` records, reflecting new contract addresses for the marketplace. ### Detailed summary - Updated `MarketplaceV3` address for `[324]` from `0x88e7F2bEf0a23073b7Cc2c79D307Dbd9138Fa79c` to `0xFD5663B3Ed316aEB79c9b5c4A242172273cA3395`. - Updated `MarketplaceV3` address for `[2741]` from `0x4b14569c7B79DBe686Ac3Ba5996131E7EDaB7a93` to `0x9Fdf34f552cdA8E2B0cD64e2EddcB732a5Ff8455`. - Added new `MarketplaceV3` address for `[531050104]`: `0x292c324920d4120F928dA6f04548442fa10B8B0f`. - Added new `MarketplaceV3` address for `[50104]`: `0x292c324920d4120F928dA6f04548442fa10B8B0f`. - Added new `WETH` address for `[531050104]`: `0x9B7EA63EF5062661570afe548e3AD691D5652527`. - Added new `WETH` address for `[50104]`: `0x2b1A859dE6A55c553520D7780Bc5805712B128F9`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`   ## Summary by CodeRabbit - **New Features** - Added support for MarketplaceV3 contract on two additional networks. - Updated MarketplaceV3 contract addresses on existing networks for improved compatibility.

kumaryash90 requested review from a team as code owners June 13, 2025 12:03

github-actions bot assigned kumaryash90 Jun 13, 2025

github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jun 13, 2025

vercel bot deployed to Preview – login June 13, 2025 12:05 View deployment

vercel bot deployed to Preview – wallet-ui June 13, 2025 12:05 View deployment

vercel bot deployed to Preview – thirdweb_playground June 13, 2025 12:06 View deployment

vercel bot deployed to Preview – thirdweb-www June 13, 2025 12:12 View deployment

vercel bot deployed to Preview – docs-v2 June 13, 2025 12:12 View deployment

0xFirekeeper approved these changes Jun 13, 2025

View reviewed changes

kumaryash90 added the merge-queue Adds the pull request to Graphite's merge queue. label Jun 13, 2025

vercel bot deployed to Preview – login June 13, 2025 13:42 View deployment

vercel bot deployed to Preview – wallet-ui June 13, 2025 13:42 View deployment

vercel bot deployed to Preview – thirdweb_playground June 13, 2025 13:42 View deployment

vercel bot deployed to Preview – thirdweb-www June 13, 2025 13:48 View deployment

vercel bot deployed to Preview – docs-v2 June 13, 2025 13:49 View deployment

graphite-app bot force-pushed the yash/update-implementations branch from 90426a2 to 64ee04c Compare June 13, 2025 13:50

vercel bot deployed to Preview – wallet-ui June 13, 2025 13:51 View deployment

vercel bot deployed to Preview – thirdweb_playground June 13, 2025 13:51 View deployment

vercel bot deployed to Preview – login June 13, 2025 13:51 View deployment

vercel bot deployed to Preview – docs-v2 June 13, 2025 13:52 View deployment

vercel bot deployed to Preview – thirdweb-www June 13, 2025 13:58 View deployment

graphite-app bot merged commit 64ee04c into main Jun 13, 2025
24 checks passed

graphite-app bot removed the merge-queue Adds the pull request to Graphite's merge queue. label Jun 13, 2025

graphite-app bot deleted the yash/update-implementations branch June 13, 2025 13:59

vercel bot deployed to Production – wallet-ui June 13, 2025 14:01 View deployment

vercel bot deployed to Production – thirdweb_playground June 13, 2025 14:02 View deployment

vercel bot deployed to Production – login June 13, 2025 14:03 View deployment

vercel bot deployed to Production – docs-v2 June 13, 2025 14:07 View deployment

vercel bot deployed to Production – thirdweb-www June 13, 2025 14:08 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update implementations #7335

Update implementations #7335

Uh oh!

kumaryash90 commented Jun 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 13, 2025

Uh oh!

coderabbitai bot commented Jun 13, 2025 •

edited

Loading

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

codecov bot commented Jun 13, 2025 •

edited

Loading

Uh oh!

kumaryash90 commented Jun 13, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Uh oh!

Update implementations #7335

Update implementations #7335

Uh oh!

Conversation

kumaryash90 commented Jun 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR-Codex overview

Detailed summary

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jun 13, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Review ran into problems

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

codecov bot commented Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kumaryash90 commented Jun 13, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

kumaryash90 commented Jun 13, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Jun 13, 2025 •

edited

Loading

vercel bot commented Jun 13, 2025 •

edited

Loading

coderabbitai bot commented Jun 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jun 13, 2025 •

edited

Loading

codecov bot commented Jun 13, 2025 •

edited

Loading

kumaryash90 commented Jun 13, 2025 •

edited by graphite-app bot

Loading