chore: Bump Nemo to 0.53, FLINT to 3.4.0#2095
Merged
thofma merged 4 commits intothofma:masterfrom Dec 4, 2025
Merged
Conversation
5 tasks
Contributor
Author
|
There are some serious-looking errors, all of the same form, e.g. https://github.com/thofma/Hecke.jl/actions/runs/19830420720/job/56814762343?pr=2095#step:6:3238: Zlattices: Error During Test at /home/runner/work/Hecke.jl/Hecke.jl/test/QuadForm/Quad/ZLattices.jl:111
Got exception outside of a @test
Flint Exception (General error):
GR_MUST_SUCCEED failure: /workspace/srcdir/flint-3.4.0/src/fmpz_lll/lll_d.c
Stacktrace:
[1] flint_throw(err_type::Nemo.FlintExceptionType, cmsg::Cstring, va_list::Ptr{Nothing})
@ Nemo ~/.julia/packages/Nemo/3UN8L/src/Nemo.jl:296
[2] lll_with_transform(x::ZZMatrix, ctx::LLLContext)
@ Nemo ~/.julia/packages/Nemo/3UN8L/src/flint/fmpz_mat.jl:962
[3] lll_with_transform
@ ~/.julia/packages/Nemo/3UN8L/src/flint/fmpz_mat.jl:960 [inlined]
[4] init_vector_sums(C::Hecke.ZLatAutoCtx{Int64, Matrix{Int64}, Vector{Int64}}, depth::Int64)
@ Hecke ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Morphism.jl:651
[5] try_init_small(C::Hecke.ZLatAutoCtx{ZZRingElem, ZZMatrix, ZZMatrix}, auto::Bool, bound::ZZRingElem, use_dict::Bool; depth::Int64, bacher_depth::Int64, is_lll_reduced_known::Bool, known_short_vectors::Tuple{Int64, Vector{Any}})
@ Hecke ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Morphism.jl:515
[6] try_init_small (repeats 3 times)
@ ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Morphism.jl:306 [inlined]
[7] __assert_has_automorphisms(L::ZZLat; redo::Bool, try_small::Bool, depth::Int64, bacher_depth::Int64, known_short_vectors::Tuple{Int64, Vector{Any}})
@ Hecke ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Quad/ZLattices.jl:460
[8] __assert_has_automorphisms
@ ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Quad/ZLattices.jl:387 [inlined]
[9] _assert_has_automorphisms_ZZLat
@ ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Quad/ZLattices.jl:385 [inlined]
[10] assert_has_automorphisms
@ ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Quad/ZLattices.jl:382 [inlined]
[11] automorphism_group_generators(L::ZZLat; ambient_representation::Bool, kwargs::@Kwargs{})
@ Hecke ~/work/Hecke.jl/Hecke.jl/src/QuadForm/Quad/ZLattices.jl:496
[12] macro expansion
@ ~/work/Hecke.jl/Hecke.jl/test/QuadForm/Quad/ZLattices.jl:275 [inlined]
[13] macro expansion
@ /opt/hostedtoolcache/julia/1.11.7/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1709 [inlined]
[14] top-level scope
@ ~/work/Hecke.jl/Hecke.jl/test/QuadForm/Quad/ZLattices.jl:115
[15] include(fname::String)
@ Main ./sysimg.jl:38
[16] top-level scope
@ ~/work/Hecke.jl/Hecke.jl/test/QuadForm/Quad.jl:5
[17] include(fname::String)
@ Main ./sysimg.jl:38
[18] macro expansion
@ ~/work/Hecke.jl/Hecke.jl/test/QuadForm.jl:9 [inlined]
[19] macro expansion
@ /opt/hostedtoolcache/julia/1.11.7/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1709 [inlined]
[20] top-level scope
@ ~/work/Hecke.jl/Hecke.jl/test/QuadForm.jl:2
[21] include(fname::String)
@ Main ./sysimg.jl:38
[22] top-level scope
@ ~/work/Hecke.jl/Hecke.jl/test/runtests.jl:286
[23] include(fname::String)
@ Main ./sysimg.jl:38
[24] top-level scope
@ none:6 |
Contributor
Author
|
I reported the errors upstream in flintlib/flint#2510. |
Contributor
Author
|
Next iteration of errors (when running locally with flintlib/flint#2511): Periods: Test Failed at /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:20
Expression: contains(C("2.7629221426067257179910708730994041505062373525092", "0"), (L[1])[1])
Evaluated: contains([2.762922142606725717991070873099 +/- 4.06e-31], [2.76292214260672571799107087310 +/- 1.13e-30])
Stacktrace:
[1] top-level scope
@ /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:3
[2] macro expansion
@ /tmpbig/goettgen/.julia/juliaup/julia-1.12.2+0.x64.linux.gnu/share/julia/stdlib/v1.12/Test/src/Test.jl:1776 [inlined]
[3] macro expansion
@ /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:4 [inlined]
[4] macro expansion
@ /tmpbig/goettgen/.julia/juliaup/julia-1.12.2+0.x64.linux.gnu/share/julia/stdlib/v1.12/Test/src/Test.jl:1776 [inlined]
[5] macro expansion
@ /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:20 [inlined]
[6] macro expansion
@ /tmpbig/goettgen/.julia/juliaup/julia-1.12.2+0.x64.linux.gnu/share/julia/stdlib/v1.12/Test/src/Test.jl:680 [inlined]
Periods: Test Failed at /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:21
Expression: contains(C("-1.3814610713033628589955354365497020752531186762546", "1.0723061100392989886753176174505371703784396785786"), (L[1])[2])
Evaluated: contains([-1.381461071303362858995535436550 +/- 6.68e-31] + [1.072306110039298988675317617451 +/- 4.65e-31]*im, [-1.381461071303362858995535436550 +/- 5.64e-31] + [1.07230611
0039298988675317617451 +/- 5.67e-31]*im)
Stacktrace:
[1] top-level scope
@ /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:3
[2] macro expansion
@ /tmpbig/goettgen/.julia/juliaup/julia-1.12.2+0.x64.linux.gnu/share/julia/stdlib/v1.12/Test/src/Test.jl:1776 [inlined]
[3] macro expansion
@ /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:4 [inlined]
[4] macro expansion
@ /tmpbig/goettgen/.julia/juliaup/julia-1.12.2+0.x64.linux.gnu/share/julia/stdlib/v1.12/Test/src/Test.jl:1776 [inlined]
[5] macro expansion
@ /tmpbig/goettgen/julia/Hecke.jl/test/EllCrv/Periods.jl:21 [inlined]
[6] macro expansion
@ /tmpbig/goettgen/.julia/juliaup/julia-1.12.2+0.x64.linux.gnu/share/julia/stdlib/v1.12/Test/src/Test.jl:680 [inlined] |
Owner
|
It is working for me locally with the changes I pushed yesterday and flintlib/flint#2510. |
Contributor
Author
|
Once flintlib/flint#2511 is merged, I will start a rebuild in Yggdrasil with that patch |
lgoettgens
commented
Dec 4, 2025
Contributor
Author
|
This looks fine now from my POV. @thofma could you take over from here, and make a patch release with this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
+ Coverage 77.01% 77.08% +0.06%
==========================================
Files 370 370
Lines 118613 118689 +76
==========================================
+ Hits 91353 91488 +135
+ Misses 27260 27201 -59 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.