Add bibtool CI job; rename milneCFT entry

.bibtoolrsc

@@ -0,0 +1,101 @@
+# This is a config file for bibtool, see
+#    http://www.gerd-neugebauer.de/software/TeX/BibTool/en/
+# To use it, invoke bibtool as follows:
+#   bibtool -r .bibtoolrsc docs/src/Hecke.bib -o docs/src/Hecke.bib
+
+sort = on
+
+# sort order for fields
+sort.order{* =
+    bibkey
+    author
+    title
+    editor
+    booktitle
+    mrnumber
+    zbl
+    journal
+    fjournal
+    series
+    volume
+    number
+    note
+    howpublished
+    address
+    organization
+    publisher
+    edition
+    pages
+    year
+    month
+    doi
+    url
+}
+
+print.align.key = 0
+print.line.length = 120
+preserve.key.case = on
+sort.cased = off
+print.use.tab = off
+
+delete.field = { abstract }
+delete.field = { hal_id }
+delete.field = { hal_version }
+delete.field = { isbn }
+delete.field = { issn }
+delete.field = { keywords }
+delete.field = { mrclass }
+delete.field = { mrreviewer }
+delete.field = { msc2010 }
+
+fmt.name.name = { }
+fmt.inter.name = { x }
+
+key.format =
+{
+    %s(bibkey)
+ #
+    %.1#n(author)
+    { %1.3n(author) }
+    { %2d(year) }
+ #
+    { %+8.1n(author) }
+    { %2d(year) }
+}
+
+# Enforce "{...}" around fields
+rewrite.rule { "^\"\([^#]*\)\"$" "{\1}" }
+rewrite.rule { "^ *\([0-9]*\) *$" "{\1}" }
+
+# Remove empty fields
+rewrite.rule { "^{ *}$" }
+
+# Unify page range separator
+rewrite.rule { pages "\([0-9]+\) *\(-\|---\|–\) *\([0-9]+\)" "\1--\3" }
+
+# Check that 1800<=year<=2029
+check.rule { year "^[\"{]1[89][0-9][0-9][\"}]$" }
+check.rule { year "^[\"{]20[0-2][0-9][\"}]$" }
+check.error.rule { year "" "\@ \$: Year has to be a suitable number" }
+
+# Check that the doi field is not a URL
+check.error.rule { doi "\://" "\@ \$: doi field should not be a URL" }
+
+# Check that the url field is not a DOI
+check.error.rule { url "doi\.org/" "\@ \$: url field should not contain a doi. Use the doi field instead" }
+
+# Normalize the month field to e.g. `jan` (without braces), see https://github.com/ge-ne/bibtool/issues/66#issuecomment-577283871
+rewrite.case.sensitive = Off
+rewrite.rule { month "{\([^#]*\)}" "\1"}
+rewrite.rule { month "^ *\(1\|Jan.*\|jan.+\) *$" "jan" }
+rewrite.rule { month "^ *\(2\|Feb.*\|feb.+\) *$" "feb" }
+rewrite.rule { month "^ *\(3\|Mar.*\|mar.+\) *$" "mar" }
+rewrite.rule { month "^ *\(4\|Apr.*\|apr.+\) *$" "apr" }
+rewrite.rule { month "^ *\(5\|May.*\|may.+\) *$" "may" }
+rewrite.rule { month "^ *\(6\|Jun.*\|jun.+\) *$" "jun" }
+rewrite.rule { month "^ *\(7\|Jul.*\|jul.+\) *$" "jul" }
+rewrite.rule { month "^ *\(8\|Aug.*\|aug.+\) *$" "aug" }
+rewrite.rule { month "^ *\(9\|Sep.*\|sep.+\) *$" "sep" }
+rewrite.rule { month "^ *\(10\|Oct.*\|oct.+\) *$" "oct" }
+rewrite.rule { month "^ *\(11\|Nov.*\|nov.+\) *$" "nov" }
+rewrite.rule { month "^ *\(12\|Dec.*\|dec.+\) *$" "dec" }

.github/workflows/BibtoolCI.yml

@@ -0,0 +1,53 @@
+name: Bibtool test
+
+on:
+  push:
+    branches:
+      - master
+      - 'release-*'
+    paths-ignore:
+      - '*.md'
+      - '.github/workflows/changelog.yml'
+      - 'dev/releases/release_notes.py'
+  pull_request:
+    paths-ignore:
+      - '*.md'
+      - '.github/workflows/changelog.yml'
+      - 'dev/releases/release_notes.py'
+  workflow_dispatch:
+
+concurrency:
+  # group by workflow and ref; the last slightly strange component ensures that for pull
+  # requests, we limit to 1 concurrent job, but for the master branch we don't
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.ref != 'refs/heads/master' || github.run_number }}
+  # Cancel intermediate builds, but only if it is a pull request build.
+  cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
+
+jobs:
+  check-standard-refs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - name: Install bibtool
+        run: |
+          sudo apt-get -y update
+          sudo apt-get install -y bibtool
+      - name: Execute bibtool and check for changes
+        run: |
+          bibtool docs/src/Hecke.bib -o docs/src/Hecke.bib 2>&1 | tee bibtool.log
+          test \! -s bibtool.log
+          rm bibtool.log
+          if [ -n "$(git status --porcelain)" ]; then
+            echo "We employ bibtool to standardize the bibtex entries of our reference list."
+            echo "Your changes to the bibliography do not follow this standard."
+            echo "Please be encouraged to adjust your bibtex entries to this standard."
+            echo "To achieve this, please invoke the following command from the root directory of Hecke.jl:"
+            echo "bibtool docs/src/Hecke.bib -o docs/src/Hecke.bib"
+            echo "(Cf. https://docs.oscar-system.org/stable/DeveloperDocumentation/documentation/#Updating-the-bibliography)"
+            echo "This script will change the bibtex entries to match our standard."
+            echo "Note: The bibkeys change too, i.e. the strings that you use in the @cite commands of the documentation."
+            echo "Therefore, you will need to adjust your @cite commands in the Hecke documentation as well."
+            exit 1
+          else
+            exit 0
+          fi

docs/src/Hecke.bib

@@ -1,123 +1,105 @@
-@book{Coh93,
-    AUTHOR = {Cohen, Henri},
-     TITLE = {A course in computational algebraic number theory},
-    SERIES = {Graduate Texts in Mathematics},
-    VOLUME = {138},
- PUBLISHER = {Springer-Verlag, Berlin},
-      YEAR = {1993},
-     PAGES = {xii+534},
-      ISBN = {3-540-55640-0},
-   MRCLASS = {11Y40 (11Rxx 68Q40)},
-  MRNUMBER = {1228206},
-MRREVIEWER = {Joe P. Buhler},
-       DOI = {10.1007/978-3-662-02945-9},
+
+@Book{CS99,
+  author        = {Conway, J. H. and Sloane, N. J. A.},
+  title         = {Sphere packings, lattices and groups},
+  mrnumber      = {1662447},
+  series        = {Grundlehren der mathematischen Wissenschaften},
+  volume        = {290},
+  publisher     = {Springer-Verlag, New York},
+  edition       = {Third},
+  pages         = {lxxiv+703},
+  year          = {1999},
+  doi           = {10.1007/978-1-4757-6568-7}
 }
 
-@book{Coh00,
-    AUTHOR = {Cohen, Henri},
-     TITLE = {Advanced topics in computational number theory},
-    SERIES = {Graduate Texts in Mathematics},
-    VOLUME = {193},
- PUBLISHER = {Springer-Verlag, New York},
-      YEAR = {2000},
-     PAGES = {xvi+578},
-      ISBN = {0-387-98727-4},
-   MRCLASS = {11Y40 (11Rxx)},
-  MRNUMBER = {1728313},
-MRREVIEWER = {Ken Yamamura},
-       DOI = {10.1007/978-1-4419-8489-0},
+@Book{Coh00,
+  author        = {Cohen, Henri},
+  title         = {Advanced topics in computational number theory},
+  mrnumber      = {1728313},
+  series        = {Graduate Texts in Mathematics},
+  volume        = {193},
+  publisher     = {Springer-Verlag, New York},
+  pages         = {xvi+578},
+  year          = {2000},
+  doi           = {10.1007/978-1-4419-8489-0}
 }
 
-@book{PZ97,
-    AUTHOR = {Pohst, M. and Zassenhaus, H.},
-     TITLE = {Algorithmic algebraic number theory},
-    SERIES = {Encyclopedia of Mathematics and its Applications},
-    VOLUME = {30},
- PUBLISHER = {Cambridge University Press, Cambridge},
-      YEAR = {1997},
-     PAGES = {xiv+499},
-      ISBN = {0-521-59669-6},
-   MRCLASS = {11Rxx (11Y40)},
-  MRNUMBER = {1483321},
+@Book{Coh93,
+  author        = {Cohen, Henri},
+  title         = {A course in computational algebraic number theory},
+  mrnumber      = {1228206},
+  series        = {Graduate Texts in Mathematics},
+  volume        = {138},
+  publisher     = {Springer-Verlag, Berlin},
+  pages         = {xii+534},
+  year          = {1993},
+  doi           = {10.1007/978-3-662-02945-9}
 }
 
-@book{Mar18,
-    AUTHOR = {Marcus, Daniel A.},
-     TITLE = {Number fields},
-    SERIES = {Universitext},
- PUBLISHER = {Springer, Cham},
-      YEAR = {2018},
-     PAGES = {xviii+203},
-      ISBN = {978-3-319-90232-6; 978-3-319-90233-3},
-   MRCLASS = {11-01 (11Rxx 11Txx 12-01)},
-  MRNUMBER = {3822326},
-       DOI = {10.1007/978-3-319-90233-3},
+@InProceedings{Han07,
+  author        = {Hanke, Timo},
+  title         = {The Isomorphism Problem for Cyclic Algebras and an Application},
+  booktitle     = {Proceedings of the 2007 International Symposium on Symbolic and Algebraic Computation},
+  series        = {ISSAC '07},
+  publisher     = {Association for Computing Machinery},
+  pages         = {181--186},
+  year          = {2007},
+  doi           = {10.1145/1277548.1277574},
+  location      = {New York, NY, USA}
 }
 
-@book{CS99,
-    AUTHOR = {Conway, J. H. and Sloane, N. J. A.},
-     TITLE = {Sphere packings, lattices and groups},
-    SERIES = {Grundlehren der mathematischen Wissenschaften},
-    VOLUME = {290},
-   EDITION = {Third},
- PUBLISHER = {Springer-Verlag, New York},
-      YEAR = {1999},
-     PAGES = {lxxiv+703},
-      ISBN = {0-387-98585-9},
-   MRCLASS = {11H31 (05B40 11H06 20D08 52C07 52C17 94B75 94C30)},
-  MRNUMBER = {1662447},
-MRREVIEWER = {Renaud Coulangeon},
-       DOI = {10.1007/978-1-4757-6568-7},
-       URL = {https://doi.org/10.1007/978-1-4757-6568-7},
+@Book{Mar18,
+  author        = {Marcus, Daniel A.},
+  title         = {Number fields},
+  mrnumber      = {3822326},
+  series        = {Universitext},
+  publisher     = {Springer, Cham},
+  pages         = {xviii+203},
+  year          = {2018},
+  doi           = {10.1007/978-3-319-90233-3}
 }
 
-@inproceedings{han07,
-    AUTHOR = {Hanke, Timo},
- BOOKTITLE = {Proceedings of the 2007 International Symposium on Symbolic and Algebraic Computation},
-       DOI = {10.1145/1277548.1277574},
-      ISBN = {9781595937438},
-  LOCATION = {New York, NY, USA},
-     PAGES = {181--186},
- PUBLISHER = {Association for Computing Machinery},
-    SERIES = {ISSAC '07},
-     TITLE = {The Isomorphism Problem for Cyclic Algebras and an Application},
-      YEAR = {2007},
+@Misc{Mil20,
+  author        = {Milne, J. S.},
+  title         = {Class Field Theory (v4.03)},
+  pages         = {287+viii},
+  year          = {2020},
+  url           = {https://www.jmilne.org/math/CourseNotes/cft.html}
 }
 
-@article{Nik79,
-    AUTHOR = {Nikulin, V. V.},
-     TITLE = {Integer symmetric bilinear forms and some of their geometric
-              applications},
-   JOURNAL = {Izv. Akad. Nauk SSSR Ser. Mat.},
-  FJOURNAL = {Izvestiya Akademii Nauk SSSR. Seriya Matematicheskaya},
-    VOLUME = {43},
-      YEAR = {1979},
-    NUMBER = {1},
-     PAGES = {111--177, 238},
-      ISSN = {0373-2436},
-   MRCLASS = {10C05 (14G30 14J17 14J25 57M99 57R45 58C27)},
-  MRNUMBER = {525944},
-MRREVIEWER = {I. Dolgachev},
+@Article{Nik79,
+  author        = {Nikulin, V. V.},
+  title         = {Integer symmetric bilinear forms and some of their geometric applications},
+  mrnumber      = {525944},
+  journal       = {Izv. Akad. Nauk SSSR Ser. Mat.},
+  fjournal      = {Izvestiya Akademii Nauk SSSR. Seriya Matematicheskaya},
+  volume        = {43},
+  number        = {1},
+  pages         = {111--177, 238},
+  year          = {1979}
 }
 
-@article{Shi15,
-    AUTHOR = {Shimada, Ichiro},
-     TITLE = {An algorithm to compute automorphism groups of $K3$ surfaces and an application to singular $K3$
-              surfaces},
-  MRNUMBER = {3456710},
-   JOURNAL = {Int. Math. Res. Not. IMRN},
-  FJOURNAL = {International Mathematics Research Notices. IMRN},
-    VOLUME = {2015},
-    NUMBER = {22},
-     PAGES = {11961--12014},
-      YEAR = {2015},
-       DOI = {10.1093/imrn/rnv006}
+@Book{PZ97,
+  author        = {Pohst, M. and Zassenhaus, H.},
+  title         = {Algorithmic algebraic number theory},
+  mrnumber      = {1483321},
+  series        = {Encyclopedia of Mathematics and its Applications},
+  volume        = {30},
+  publisher     = {Cambridge University Press, Cambridge},
+  pages         = {xiv+499},
+  year          = {1997}
 }
 
-@misc{milneCFT,
-    AUTHOR = {J.S. Milne},
-     TITLE = {Class Field Theory (v4.03)},
-      YEAR = {2020},
-      NOTE = {Available at www.jmilne.org/math/},
-     PAGES = {287+viii}
+@Article{Shi15,
+  author        = {Shimada, Ichiro},
+  title         = {An algorithm to compute automorphism groups of $K3$ surfaces and an application to singular $K3$
+                  surfaces},
+  mrnumber      = {3456710},
+  journal       = {Int. Math. Res. Not. IMRN},
+  fjournal      = {International Mathematics Research Notices. IMRN},
+  volume        = {2015},
+  number        = {22},
+  pages         = {11961--12014},
+  year          = {2015},
+  doi           = {10.1093/imrn/rnv006}
 }

docs/src/manual/number_fields/class_fields.md

@@ -23,7 +23,7 @@ of ideals coprime to $m_0$ modulo the elements $a\in K^*$ such that
 v_p(a-1) \ge v_p(m_0) \mbox{ and for all } v\in m_\infty,\, a^{(v)}>0.
 ```
 
-This is a finite abelian group, cf. [milneCFT](@cite) (Theorem 1.7, Chapter V).
+This is a finite abelian group, cf. [Mil20](@cite) (Theorem 1.7, Chapter V).
 
 For $m_0 = \mathcal{O}_K$ and $m_\infty = \emptyset$ the empty list, we
 get a ray class group $Cl$ that is simply the class group of $K$.

src/AlgAss/AlgCyc.jl

@@ -253,7 +253,7 @@ true
 
 # References
 
-Algorithm as described in [han07](@cite).
+Algorithm as described in [Han07](@cite).
 """
 function is_isomorphic_with_map(
   c1::CyclicAlgebra{T},