Fix multi-app staking flow #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `Authorize Selected Apps` button if all apps have been authorized because htere arre no longer any more apps to select.
Remove the authorized app from selected apps state if the application has been authorized. In the previous impl was an issue that selected apps were still selected after authorization tx and user was able to click the `Authorize Selected Apps` again. This commit fixes this issue.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/update-auth-page/index.html. |
Each word on the button should start with capital letters.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/update-auth-page/index.html. |
michalsmiarowski
requested changes
Oct 24, 2022
We should use the `selectedApps` param from a callback function of `useState` hook to filter out the `randomBeacon` app if needed.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/update-auth-page/index.html. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #244
This PR removes
Authorize Selected Appsbutton if all apps have been authorized because there are no longer any more apps to select. It also fixes an issue with selected apps after authorization transaction- the authorized app was not removed from theselectedAppsarray so the user was able to click theAuthorize Selected Appsagain.