OvmfPkg: Use the OvmfPkg version of CcProbeLib#10597
Merged
mergify[bot] merged 2 commits intotianocore:masterfrom Jan 13, 2025
Merged
OvmfPkg: Use the OvmfPkg version of CcProbeLib#10597mergify[bot] merged 2 commits intotianocore:masterfrom
mergify[bot] merged 2 commits intotianocore:masterfrom
Conversation
Currently, multiple dsc files within the OvmfPkg directory use the NULL
version of the CcProbeLib library. However, these packages have support
for confidential guests (usage of CcExitLib, MemEncrypt{Sev,Tdx}Lib, etc.)
and should be using the OvmfPkg version of the CcProbeLib.
The use of the NULL library causes the PCI option ROM to be enabled, which
can't be trusted as it originates from the hypervisor. The use of the NULL
library also causes a KVM hypervisor error when attempting to map/back the
option ROM region when running an SEV-SNP guest.
Update the various dsc files to reference the OvmfPkg version of the
CcProbeLib library and prevent usage of PCI option ROMs.
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
github-actions
Bot
added
the
impact:security
tianocore-assign-reviewers
Bot
requested review from
ardbiesheuvel,
jongwu,
jyao1,
mdroth,
mxu9,
ruleof2 and
weltling
Contributor
Author
Member
|
I can test microvm tomorrow. Not sure about cloudhw, I'd suggest to check the commit log. |
Contributor
Author
Ok, I was able to boot an image using Cloud Hypervisor. |
fitzthum
approved these changes
Jan 9, 2025
Contributor
fitzthum
left a comment
fitzthum
left a comment
There was a problem hiding this comment.
LGTM. Surprising that we didn't notice this regression earlier.
jyao1
approved these changes
Jan 10, 2025
Member
|
microvm is broken in master, looking ... |
kraxel
approved these changes
Jan 10, 2025
ardbiesheuvel
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, multiple dsc files within the OvmfPkg directory use the NULL version of the CcProbeLib library. However, these packages have support for confidential guests (usage of CcExitLib, MemEncrypt{Sev,Tdx}Lib, etc.) and should be using the OvmfPkg version of the CcProbeLib.
The use of the NULL library causes the PCI option ROM to be enabled, which can't be trusted as it originates from the hypervisor. The use of the NULL library also causes a KVM hypervisor error when attempting to map/back the option ROM region when running an SEV-SNP guest.
Update the various dsc files to reference the OvmfPkg version of the CcProbeLib library and prevent usage of PCI option ROMs.
How This Was Tested
This was tested by launching SEV, SEV-ES and SEV-SNP guest using the AmdSev package. I have not tested the changes to the CloudHv or the Microvm packages.
Integration Instructions
N/A