Skip to content

MdePkg: Fix Clang Build Error#10689

Merged
mergify[bot] merged 1 commit intotianocore:masterfrom
sachinami:Sachin/ClangFix
Jan 28, 2025
Merged

MdePkg: Fix Clang Build Error#10689
mergify[bot] merged 1 commit intotianocore:masterfrom
sachinami:Sachin/ClangFix

Conversation

@sachinami
Copy link
Copy Markdown
Contributor

@sachinami sachinami commented Jan 28, 2025 •
edited
Loading

Description

Fixed Clang build error introduced by uninitialized variables in 6278bbb

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Integration Instructions

N/A

@sachinami
MdePkg: Fix Clang Build Error
362e3ea 
Fixed Clang build error introduced by unintialized variables in
tianocore@6278bbb

Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
@sachinami
Copy link
Copy Markdown
Contributor Author

sachinami commented Jan 28, 2025

@ardbiesheuvel Fixed issue introduced in #10617

@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Jan 28, 2025
@mergify mergify Bot merged commit 428cd8a into tianocore:master Jan 28, 2025
@sachinami sachinami mentioned this pull request Jan 28, 2025
Merged
3 tasks
@mdkinney
Copy link
Copy Markdown
Member

mdkinney commented Jan 28, 2025

Thanks for the quick fix to this CLANG compatibility issue. I would like to see CLANG added to CI to help catch these types of issues before they are merged.

@ardbiesheuvel
Copy link
Copy Markdown
Member

ardbiesheuvel commented Jan 28, 2025

Thanks for the quick fix to this CLANG compatibility issue. I would like to see CLANG added to CI to help catch these types of issues before they are merged.

Agreed. We could swap out some GCC5 targets with CLANGDWARF so we don't have to increase the overall CI workload.

@mdkinney mdkinney mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardbiesheuvel ardbiesheuvel ardbiesheuvel approved these changes

@lgao4 lgao4 Awaiting requested review from lgao4

@mdkinney mdkinney Awaiting requested review from mdkinney

Assignees

No one assigned

Labels

push Auto push patch series in PR if all checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sachinami @mdkinney @ardbiesheuvel