Skip to content

Introduce Redfish Platform Wanted Device Lib#10999

Merged
mergify[bot] merged 3 commits intotianocore:masterfrom
nicklela:redfish-wanted-device-lib
May 1, 2025
Merged

Introduce Redfish Platform Wanted Device Lib#10999
mergify[bot] merged 3 commits intotianocore:masterfrom
nicklela:redfish-wanted-device-lib

Conversation

@nicklela
Copy link
Copy Markdown
Contributor

Description

Introduce platform wanted device lib to RedfishPkg. This library provide the flexibility for platform owner to device which device we like to support Redfish service. This helps to reduce boot time and resource on devices that is not host interface.

A null library is implemented and it accepts all devices as default behavior.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

N/A

Integration Instructions

N/A

@nicklela nicklela requested a review from changab April 24, 2025 02:46
@nicklela nicklela self-assigned this Apr 24, 2025
@nicklela nicklela force-pushed the redfish-wanted-device-lib branch 2 times, most recently from 4085ad2 to bdc35fe Compare April 24, 2025 06:02
Introduce platform wanted device lib to RedfishPkg. This library
provide the flexibility for platform owner to device which device we like
to support Redfish service. This helps to reduce boot time and resource
on devices that is not host interface.

A null library is implemented and it accepts all devices as default
behavior.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
In supported() function, add the call to platform device wanted lib to
see if platform wants to support this device or not. If platform does
not support this device, Redfish Ex protocol won't be available on this
controller handle and the reset of Redfish service is not available
either.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
@nicklela nicklela force-pushed the redfish-wanted-device-lib branch from bdc35fe to d2ef2f4 Compare April 30, 2025 02:48
@nicklela
Copy link
Copy Markdown
Contributor Author

@igorkulchytskyy can you please check this change if you have chance? This gives platform a way to limit Redfish service to specific interface, which improve the boot performance.

@igorkulchytskyy
Copy link
Copy Markdown
Contributor

@igorkulchytskyy can you please check this change if you have chance? This gives platform a way to limit Redfish service to specific interface, which improve the boot performance.

Hi Nickle,
let me clarify what I understand.
This library is going to be used by RestEx driver to select which network interface (if we have several) should be used to access Redfish service. Is my understanding correct?
Thank you,
Igor

@nicklela
Copy link
Copy Markdown
Contributor Author

@igorkulchytskyy can you please check this change if you have chance? This gives platform a way to limit Redfish service to specific interface, which improve the boot performance.

Hi Nickle,

let me clarify what I understand.

This library is going to be used by RestEx driver to select which network interface (if we have several) should be used to access Redfish service. Is my understanding correct?

Thank you,

Igor

Yes! Your understanding is correct.

Copy link
Copy Markdown
Contributor

@igorkulchytskyy igorkulchytskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nicklela nicklela added the push Auto push patch series in PR if all checks pass label May 1, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented May 1, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify Bot merged commit 225bf12 into tianocore:master May 1, 2025
126 checks passed
@lgao4 lgao4 added the type:feature-request A new feature proposal label May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

push Auto push patch series in PR if all checks pass type:feature-request A new feature proposal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants