fix(android): disable ripple in M3 BottomNavigation#14445
Conversation
hansemannn
left a comment
There was a problem hiding this comment.
touchFeedback: false should not disable the custom tab background state handling. The current change gates createBackgroundDrawableForState() behind hasTouchFeedback, then clears the item background when touch feedback is disabled. That fixes the ripple, but it also drops selected/background state colors such as tabsBackgroundSelectedColor or backgroundFocusedColor when a tab has touchFeedback: false.
Please keep applying the custom state background drawable independently of touch feedback, and only skip wrapping it in a RippleDrawable when touch feedback is disabled.
|
@hansemannn Updated the PR and added an example with |

Currently
touchFeedback: falsehas no effect in an experimental BottomNavigation with M3 theme:Bildschirmaufnahme_20260514_112044.webm
This PR will respect the touchFeedback: false setting:
Bildschirmaufnahme_20260514_111903.webm
Test
tabsBackgroundSelectedColorto see the backgroundColor