Natural Earth Road and Ferry need normalized kind values

[nvkelso]

The Ferry between UK and France and the two islands of New Zealand are showing up as Ferry at zoom 7, and then it's ferry from OSM after that.

/cc @sensescape

[rmarianski]

@nvkelso looks like the ne roads will come back with a kind of Road too. We should probably normalize those as well. What should they be? highway, major_road?

[rmarianski]

We're passing through some more of the ne properties. Should we try to normalize those into a kind to match what we do for osm data?

[nvkelso]

@rmarianski what does this line do?

vector-datasource/yaml/roads.yaml

Line 116 in 1551301

name: {col: name, ignore: true}

name: {col: name, ignore: true}

[rmarianski]

Looks to be an implementation detail to work around duplicate parameters in the function signature. It still worked for me locally when removing all ignore references from the yaml, so maybe we should drop them to prevent confusion in the future.

[nvkelso]

@nvkelso looks like the ne roads will come back with a kind of Road too. We should probably normalize those as well. What should they be? highway, major_road?

Good idea! Here's a lookup table using the Type values in NE using the High Road lens and moving towards the new kind_detail to store the equivalent OSM values (but not in the highway property).

"ne:Type","tilezen:kind","tilezen:kind_detail"
"Major Highway","highway","motorway"
"Beltway","highway","motorway"
"Bypass","highway","motorway"
"Secondary Highway","major_road","trunk"
"Road","major_road","primary"
"Track","path","track"
"Unknown","minor_road","unclassified"
"Ferry Route","ferry",""
"Ferry, seasonal","ferry","seasonal_ferry"

[rmarianski]

Do we still want to pass through the ne properties? Sounds like the normalization can allow us to remove type. That ok with you?

Is level still useful?

For roads the level values are:

• U/C
• Federal
• Other
• Interstate
• State
• Ferry
• E

And for ferries:

• Other
• Ferry
• E

[rmarianski]

Looking through the data, it seems like we'll never show any seasonal ferries from ne, because they all have a scalerank of 9, and we only query osm data starting at z8+.

[nvkelso]

Should we ignore them or keep them in there in case someone changes the
ne-osm zoom switchover later?

On Thu, Jul 14, 2016 at 2:26 PM, Robert Marianski notifications@github.com
wrote:

Looking through the data, it seems like we'll never show any seasonal
ferries from ne, because they all have a scalerank of 9, and we only query
osm data starting at z8+.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#890 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA0EO5U5WOLQz2wDbgMT5CZ5rhHU5D25ks5qVqmPgaJpZM4JK8IW
.

[nvkelso]

Looking more closely at the data, there are only 5 seasonal ferries so let's just ignore them.

Yes, let’s remove NE’s type value.

The level stuff is more complicated. I think it could potentially be useful for shield generation so let's leave it in there for now. But we probably need to deal with it before the v1.0 release.

[nvkelso]

@rmarianski Hmmm, looks like expressway from Natural Earth is a better approximation of motorway:

Updated table, including ferry:

"ne:Type","ne:expressway","tilezen:kind","tilezen:kind_detail"
,1,"highway","motorway"
"Major Highway",,"highway","trunk"
"Beltway",,"highway","trunk"
"Bypass",,"highway","trunk"
"Secondary Highway",,"major_road","primary"
"Road",",major_road","secondary"
"Track",,"minor_road","tertiary"
"Unknown",,"minor_road","tertiary"
"Ferry Route",,"ferry",""
"Ferry, seasonal",,"ferry","ferry"