Fixes #1293 - Webpack doesn't seem to be reloading the frontend

[jonespm]

Is anyone else on any platform seeing this issue?

Maybe it's just because I have "Use gRPC FUSE" unchecked? I'll try to restart with that checked.

Okay it's only seems like this is an issue if that option is unchecked.

[jonespm]

Some of these ideas seemed to be included in #996 but that wasn't ever merged.

[ssciolla]

@jonespm, why is this necessary if you just needed to check the "Use gRPC FUSE for file sharing" option? Is that not something we should be doing?

Maybe these changes are good for other reasons, but if the option change is all that's needed to fix webpack, I'm thinking this PR and the issue should be renamed.

[jonespm]

I'd mentioned in the ticket that unchecking this option gets the builds and startup to go about twice as fast. It seems like there's still a performance issue with Docker on OSX and at least going back with these options fixes it.

I'm also not 100% sure if this is an issue with Windows or not. I was hearing from Daniel Zhang that his webpack wasn't reloading on Windows in the Canvas App Explorer project. It might just be related to the watch options there, as I'm seeing these volume options are only applicable to OSX without gRPC.

[pushyamig]

@jonespm I think in past i had problem when Use gRPC FUSE was checked, but not anymore(maybe after upgrade of Docker version). Now I have that checked and I didn't even applied changes from this PR and I can see webpack is creating a new main-xx.js bundle each time.

I will approve this request since this is fixing problem on Windows and is working for Mac.

[ssciolla]

@pushyamig, did you test this? If so, can you approve?

[jonespm]

Thanks! I was going to do a small fix and ensure the watchOptions was only set when development was enabled. I'm not entirely sure why I even had to add that to get it working either.

Is it already setting watch: true in dev and watch: false in prod? Then I guess it's all set as watchOptions don't matter if it's false.

https://webpack.js.org/configuration/watch/

[jonespm]

Okay looks like the webpack_watcher container locally is running watch explicitly. So this should be fine. Thanks for checking!