util: add documentation about cancel safety of SinkExt::send
#6417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maminrayej
added
T-docs
Darksonn
reviewed
Mar 23, 2024
Darksonn
approved these changes
Mar 24, 2024
Contributor
Darksonn
left a comment
Darksonn
left a comment
There was a problem hiding this comment.
I think it would be good to add a similar comment about StreamExt::next. Whether you want to do that in this PR or not is up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since types in different sub-modules in
tokio-utilimplementSink, I decided to put the doc in the top level module.Resolves #5310.