-
-
Notifications
You must be signed in to change notification settings - Fork 205
workaround for :move bug with folds. fixes #96 #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Can you be more specific? I tested it locally and it works perfectly for me, if something is wrong I doubt it's a syntax error |
I'm on mobile but it seems like a | is missing that definitely shouldn't be locally. Either that or for some weird reason it works anyway. Cant check until tonight |
Yes a |
I agree it's missing, but have you pulled this locally and tried it? The map works, although I honestly don't know why, I would expect it not to now that I've looked more carefully. I am not sure how you would like to see this implemented if not with a string eval, but I'm happy to change it, I just want to see this functionality merged asap |
I see now, |
Take your additions and move them outside the quotes onto their own lines. |
fixed. do you think it would be better to use window local fdm? |
changed it to use local values, that seems much cleaner. tested it and it works fine. should be ready to merge now I think |
ping |
In addition to the workaround, I added a
silent!
to theMoveSelectionDown()
function, as I couldn't see a good reason why it wasn't already there, and assumed it was an oversight. Let me know if it was left out for a reason.