feat(grammar): Refactor modifiers for better querying #211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #204.
Right now, modifiers like
public
orstatic
are just anonymous keywords in the AST. This makes it a pain to write queries for them without matching on text.This PR makes them actual nodes, similar to how
tree-sitter-typescript
handles it.Changes:
New
(visibility)
node:public
,protected
,private
are now grouped under this node.New
(modifier)
node:static
,final
,abstract
, etc., now all produce a(modifier)
node.Resulting AST:
For
public static class...
, the AST is now much cleaner:Closes #204.