Skip to content

Add Tronbyt S3 Device #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

Add Tronbyt S3 Device #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5aa0ad
not working
tavdog Apr 15, 2025
e8ebeed
working with psram
tavdog Apr 15, 2025
bd3001c
fix pixoticker boardname
tavdog Apr 15, 2025
d18aa08
double buffering is fine.
tavdog Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ sdkconfig.old
secrets.json
.DS_Store
build
.DS_Store
53 changes: 53 additions & 0 deletions boards/tronbyt-S3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{
"build": {
"arduino": {
"ldscript": "esp32s3_out.ld",
"partitions": "default_16MB.csv",
"memory_type": "qio_opi"
},
"core": "esp32",
"extra_flags": [
"-DARDUINO_ESP32S3_DEV",
"-DBOARD_HAS_PSRAM",
"-DARDUINO_USB_MODE=1",
"-DARDUINO_USB_CDC_ON_BOOT=1"
],
"f_cpu": "240000000L",
"f_flash": "80000000L",
"flash_mode": "qio",
"psram_type": "opi",
"hwids": [
[
"0x303A",
"0x1001"
]
],
"mcu": "esp32s3",
"variant": "esp32s3"
},
"connectivity": [
"wifi",
"bluetooth"
],
"debug": {
"default_tool": "esp-builtin",
"onboard_tools": [
"esp-builtin"
],
"openocd_target": "esp32s3.cfg"
},
"frameworks": [
"arduino",
"espidf"
],
"name": "Espressif ESP32-S3-DevKitC-1-N16R8V (16 MB QD, 8MB PSRAM)",
"upload": {
"flash_size": "16MB",
"maximum_ram_size": 327680,
"maximum_size": 16777216,
"require_upload_port": true,
"speed": 921600
},
"url": "https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/hw-reference/esp32s3/user-guide-devkitc-1.html",
"vendor": "Espressif"
}
4 changes: 3 additions & 1 deletion extra_scripts/reset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
PRODUCTION_VERSION = {
"tidbyt": "v10/35833",
"pixoticker": "v10/35833",
"tidbyt-gen2": "v11/35369"
"tronbyt-S3": "v10/35833",
"tidbyt-gen2": "v11/35369",
"matrixportal-s3": "v11/35369" # just to shut up the errors.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment "# just to shut up the errors." is not very descriptive. Can you provide a more detailed explanation of why matrixportal-s3 is added here and what errors it prevents? This will help future maintainers understand the purpose of this line.

}[env["PIOENV"]]

def fetch_firmware():
Expand Down
34 changes: 34 additions & 0 deletions platformio.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,40 @@ build_flags =
lib_deps =
https://github.com/webmproject/libwebp.git#1d86819f49edc8237fa2b844543081bcb8ef8a92
https://github.com/mrcodetastic/ESP32-HUB75-MatrixPanel-DMA.git#aed04adfcda1838bf85c629a8c3b560919b3a327 ; commit as of 20250320


; _______ _ _ _____ ____
; |__ __| | | | | / ____|___ \
; | |_ __ ___ _ __ | |__ _ _| |_ _____| (___ __) |
; | | '__/ _ \| '_ \| '_ \| | | | __|______\___ \ |__ <
; | | | | (_) | | | | |_) | |_| | |_ ____) |___) |
; |_|_| \___/|_| |_|_.__/ \__, |\__| |_____/|____/
; __/ |
; |___/
;###################################################################################
;###################################################################################
[env:tronbyt-S3]
board = esp32-s3-devkitc-1
board_build.partitions = boards/default_8mb.csv
board_build.arduino.memory_type = qio_opi
board_build.flash_mode = qio
board_build.psram_type = opi
board_upload.flash_size = 16MB
board_upload.maximum_size = 16777216
board_build.extra_flags =
-DBOARD_HAS_PSRAM
board_build.cmake_extra_args =
-DSDKCONFIG_DEFAULTS="sdkconfig.tronbyt-S3.defaults;" ; copied psram stuff from defaults
Comment on lines +129 to +130
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The sdkconfig.tronbyt-S3.defaults file is referenced here, but it is not included in the pull request. This file is necessary for configuring the ESP-IDF build for the Tronbyt S3 device. Please add this file to the pull request.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment "; copied psram stuff from defaults" is not very descriptive. Can you provide a more detailed explanation of what "psram stuff" was copied and why? This will help future maintainers understand the purpose of this line.

build_flags =
-D NO_GFX
-D NO_FAST_FUNCTIONS
-D TRONBYT_S3
; -D NO_INVERT_CLOCK_PHASE
-D BOOT_WEBP_TRONBYT ; not required as this is the default
; -D BOOT_WEBP_PARROT ; smaller size boot for pixoticker
-D HTTP_BUFFER_SIZE_MAX=220000
-D HTTP_BUFFER_SIZE_DEFAULT=100000

lib_deps =
https://github.com/webmproject/libwebp.git#1d86819f49edc8237fa2b844543081bcb8ef8a92
https://github.com/mrcodetastic/ESP32-HUB75-MatrixPanel-DMA.git#aed04adfcda1838bf85c629a8c3b560919b3a327 ; commit as of 20250320
Loading