Skip to content

esp_websocket_client: bump default task stack size to 8192 bytes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

esp_websocket_client: bump default task stack size to 8192 bytes #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ void app_main(void) {
// setup ws event handlers
const esp_websocket_client_config_t ws_cfg = {
.uri = url_to_use,
.task_stack = 8192,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The value 8192 for task_stack is a "magic number". It's good practice to define this as a named constant (e.g., WEBSOCKET_TASK_STACK_SIZE_FOR_TLS) at the top of the file or in a relevant configuration header. This improves code readability and maintainability.

      .task_stack  = WEBSOCKET_TASK_STACK_SIZE_FOR_TLS,

.buffer_size = 10000,
.crt_bundle_attach = esp_crt_bundle_attach,
};
Expand Down