add wifi_shutdown_ap timer for 2 minute timeout

[tavdog]

On boot add a 2 minute timer to deactivate the config portal ap

[gemini-code-assist]

Summary of Changes

Hello @tavdog, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces an automated mechanism to enhance the security and resource management of the device's Wi-Fi configuration portal. It ensures that the Access Point (AP) used for initial setup is automatically deactivated after a predefined period, preventing it from remaining open indefinitely.

Highlights

• Automatic AP Shutdown Timer: A 5-minute one-shot timer is now initiated upon device boot to automatically shut down the Wi-Fi Access Point (AP) used for configuration.
• Dedicated AP Shutdown Function: A new wifi_shutdown_ap function has been added to src/wifi.c which handles stopping the web server and switching the Wi-Fi mode to Station (STA), effectively closing the configuration portal.
• API Exposure: The wifi_shutdown_ap function is now declared in src/wifi.h, making it available for use within the application.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request introduces a 5-minute timeout to automatically shut down the Wi-Fi AP configuration portal. The implementation uses a FreeRTOS timer. My review focuses on critical aspects of this timer usage:

1. Correct Timer Callback Signature: The wifi_shutdown_ap function, used as the timer callback, must have its signature changed from void wifi_shutdown_ap() to void wifi_shutdown_ap(TimerHandle_t xTimer) in both its definition (wifi.c) and declaration (wifi.h) to comply with FreeRTOS TimerCallbackFunction_t.
2. Error Handling: Added suggestions to check the return values of xTimerCreate and xTimerStart in main.c to prevent potential crashes or silent failures.
3. Resource Management: Recommended deleting the one-shot timer within its callback function (wifi_shutdown_ap) after it has executed to free up system resources.

Addressing these points will improve the robustness and correctness of the new AP shutdown feature.

[tavdog]

/gemini review

[gemini-code-assist]

Code Review

This pull request adds a FreeRTOS timer to automatically shut down the WiFi configuration portal's Access Point (AP) mode after a period of time. The changes involve creating and starting the timer in main.c, adding a new wifi_shutdown_ap function in wifi.c to handle the AP shutdown logic, and declaring this function in wifi.h. The PR also includes minor formatting changes in wifi.c and adds notes to the configuration web page HTML.

Key feedback points include a discrepancy between the timer duration specified in the PR title/description (5 minutes) and the code implementation (2 minutes), and important considerations for error handling and timer management within the timer callback function to prevent system crashes and avoid redundant operations.

[tavdog]

fixes #41