Skip to content

wait for completion on otel #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sfc-gh-pdharmana
Copy link
Contributor

@sfc-gh-pdharmana sfc-gh-pdharmana commented Jun 25, 2025

Description

Please include a summary of the changes and the related issue that can be
included in the release announcement. Please also include relevant motivation
and context.

Other details good to know for developers

Please include any other details of this change useful for TruLens developers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

Important

Adds wait_for_completion method in App to ensure OTEL operations complete, integrated into start in run.py.

  • Behavior:
    • Adds wait_for_completion(timeout: float = 60.0) -> bool in App in app.py to wait for all operations to complete with OTEL tracing.
    • Integrates wait_for_completion in start() in run.py to ensure app operations complete after invocation.
  • Error Handling:
    • Raises RuntimeError in wait_for_completion if OTEL tracing is not enabled.
    • Logs a warning in start() if wait_for_completion fails or times out.
  • Misc:
    • Adds logging in start() in run.py to indicate waiting for app operations.

This description was created by Ellipsis for 84bd412. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant