bugfix: interrupts sampler may fail to sample all interrupts #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in twitter#224, the interrupts sampler can get tripped up by lines which do not match the expected keywords. This is a result of using a while loop with continue expression that bypass clearing the line buffer. This PR addresses this issue by reimplementing the loop so that we can clear the line buffer at the start of the loop. This approach allows us to ensure the line buffer is empty without requiring us to remember to clear the buffer immediately before a continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #224, the interrupts sampler can get tripped up by
lines which do not match the expected keywords. This is a result of
using a while loop with continue expression that bypass clearing
the line buffer.
This PR addresses this issue by reimplementing the loop so that we
can clear the line buffer at the start of the loop. This approach
allows us to ensure the line buffer is empty without requiring us
to remember to clear the buffer immediately before a continue.