Skip to content

Conversation

@brayniac
Copy link
Contributor

Problem

Older cstate names appended the microarchitecture abbreviation. For
example C1E-SKX for Intel Skylake's C1E state. Since the cstate
parsing logic assumed newer kernel versions which use a simpler
naming convention, it does not properly track time in each cstate
on older kernels.

Reported in #224

Solution

Improves the cstate parsing to split on '-' and take the first
token as the cstate name.

Result

As a result, the cstate sampling should work on older kernels.

Older cstate names appended the microarchitecture abbreviation. For
example C1E-SKX for Intel Skylake's C1E state. Since the cstate
parsing logic assumed newer kernel versions which use a simpler
naming convention, it does not properly track time in each cstate
on older kernels.

Improves the cstate parsing to split on '-' and take the first
token as the cstate name.

As a result, the cstate sampling should work on older kernels.
@brayniac brayniac merged commit 30827f5 into twitter:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant