Adding srtt metric in the TCP sampler via BPF #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brayniac
suggested changes
Aug 25, 2021
Contributor
brayniac
left a comment
brayniac
left a comment
There was a problem hiding this comment.
Overall this looks great and will be an excellent addition to Rezolus. Please be sure to sign the CLA and address the feedback in this review. Once those are done and tests are passing, we can merge this.
Contributor
|
Note: the cargo audit test failure is unrelated to this change and will not block merge. |
Contributor
Author
|
Addressed the comments |
brayniac
approved these changes
Aug 26, 2021
Contributor
brayniac
left a comment
brayniac
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks again for adding this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the TCP sampler does not support TCP RTT (round-trip time) metric, which is useful to analyse the quality of the network.
Solution
Introduced a new kprobe using BPF and collect RTT metric in a histogram in kernel space, and export it to the TCP sampler.
Result
The metric is supported as 'tcp/srtt' metric