Add TLP and retransmit timeouts counters to TCP sampler #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WUMUXIAN
suggested changes
Nov 10, 2021
Contributor
WUMUXIAN
left a comment
WUMUXIAN
left a comment
There was a problem hiding this comment.
the tlp one looks correct, but I think the RTO one needs to change to another kernel probe.
brayniac
reviewed
Nov 10, 2021
Contributor
brayniac
left a comment
brayniac
left a comment
There was a problem hiding this comment.
Other than the metric name, this looks good. I think it might be better overall to keep grouping metrics that are on the TX path together.
brayniac
approved these changes
Nov 16, 2021
WUMUXIAN
pushed a commit
to WUMUXIAN/rezolus
that referenced
this pull request
Nov 17, 2021
* Add TCP Tail Loss Recovery Probes sampler via BPF * Add TCP Retransmit timeout sampler via BPF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add two new TCP probes:
Solution
Added two BPF kernel probes to count TLP and RTO events.
Result
Two new metrics introduced to TCP sampler: