build: remove vergen from build #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vergen was being used to produce additional debug information about the toolchain and target that were used at build time. We can simplify the build and remove this dependency as the debug information is not high-value. This fixes twitter#277 where release archives fail to build because vergen combined with the lack of a git structure in the release archive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vergen was being used to produce additional debug information
about the toolchain and target that were used at build time.
We can simplify the build and remove this dependency as the debug
information is not high-value. This fixes #277 where release
archives fail to build because vergen combined with the lack of a
git structure in the release archive.