Fix dependencies, update yarn, add corepack to README.md #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
reviewed
Nov 3, 2024
Owner
tyrasd
left a comment
tyrasd
left a comment
There was a problem hiding this comment.
Can you please explain a little bit more what exactly the issues were that you are trying to fix here? At first glance, I personally did not experience any problems with the mentioned dependencies and am also not using corepack. Thanks!
Contributor
|
I'm one of the maintainers of OpenHistoricalMap forks. We've had to update yarn and add corepack to stay current with tasking-manager but we're not experiencing any problems with the version of yarn specified here for overpass-turbo. I'm not opposed to staying current but for us the current setup is working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated yarn to a working version, changed some of the non-working dependencies in package.json and added the step that corepack is needed for the build.