Skip to content

fix multiple potential vulnerabilities such as division-by-zero, heap-based buffer overflow and etc.#1139

Closed
YangY-Xiao wants to merge 13 commits intouclouvain:masterfrom
YangY-Xiao:master
Closed

fix multiple potential vulnerabilities such as division-by-zero, heap-based buffer overflow and etc.#1139
YangY-Xiao wants to merge 13 commits intouclouvain:masterfrom
YangY-Xiao:master

Conversation

@YangY-Xiao
Copy link
Copy Markdown

To avoid divisions by zero / undefined behaviour on shift.

@YangY-Xiao YangY-Xiao changed the title To avoid divisions by zero / undefined behaviour on shift fix multiple potential vulnerabilities such as division-by-zero, heap-based buffer overflow and etc. Aug 30, 2018
@rouault
Copy link
Copy Markdown
Collaborator

rouault commented Sep 22, 2018

Would you mind rewording the commit message by prefixing them with "[JPWL] " so that it is clear which component is affected ?

@YangY-Xiao
Copy link
Copy Markdown
Author

@rouault
done!

@rouault
Copy link
Copy Markdown
Collaborator

rouault commented Sep 26, 2018

There's an indentation issue. See https://travis-ci.org/uclouvain/openjpeg/jobs/433451076 . Use scripts/prepare_commit.sh to fix it

@rouault
Copy link
Copy Markdown
Collaborator

rouault commented Sep 26, 2018

can you integrate the indentation fix into the appropriate commit so as to have a clean history ?

@rouault
Copy link
Copy Markdown
Collaborator

rouault commented Oct 18, 2018

@Young-X I'm confused by the history of this branch. Could you rebase on top of master, and try to clean it a bit ?

@YangY-Xiao
Copy link
Copy Markdown
Author

I made a new pr #1168.

@YangY-Xiao YangY-Xiao closed this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants