jp3d/jpwl convert: fix write stack buffer overflow#1160
Merged
rouault merged 2 commits intouclouvain:masterfrom Nov 16, 2018
Merged
jp3d/jpwl convert: fix write stack buffer overflow#1160rouault merged 2 commits intouclouvain:masterfrom
rouault merged 2 commits intouclouvain:masterfrom
Conversation
Missing buffer length formatter in fscanf call might lead to write stack buffer overflow. fixes uclouvain#1044 (CVE-2017-17480)
Tile components in a JP2 image might have null data pointer by defining a zero component size (for example using large horizontal or vertical sampling periods). This null data pointer leads to null image component data pointer, causing crash when dereferenced without != null check in imagetopnm. Add != null check. This commit addresses uclouvain#1152 (CVE-2018-18088).
Contributor
Author
|
FTR, I have added a second fix addressing #1152. A few comments:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing buffer length formatter in fscanf call might lead to write stack buffer overflow.
(same patch as e528531)
Fixes #1044 (CVE-2017-17480).