Fix cmake file with DESTDIR#1321
Merged
rouault merged 2 commits intouclouvain:masterfrom Jan 10, 2021
ffontaine:master
Merged
Conversation
Fix #1174 by replacing ABSOLUTE by REALPATH which will resolve symlinks: https://cmake.org/cmake/help/latest/command/get_filename_component.html Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Collaborator
|
@matthew-sharp Can you test this PR ? |
Contributor
|
This PR works for me. Apologies for breaking cross-compile. |
Collaborator
Thanks for the feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6558637 which breaks cross-compilation of poppler under buildroot (because of
DESTDIRusage). Instead,ABSOLUTEis replaced byREALPATHto resolve symlinks (https://cmake.org/cmake/help/latest/command/get_filename_component.html)