Missed conversion from unsigned int to OPJ_INT32 #1398
Merged
rouault merged 45 commits intouclouvain:masterfrom Jan 16, 2022
Merged
Missed conversion from unsigned int to OPJ_INT32 #1398rouault merged 45 commits intouclouvain:masterfrom
rouault merged 45 commits intouclouvain:masterfrom
Conversation
…press, opj_dump. See comment on commit 79c7d7a.
Removed automatically generated settings.json
This reverts commit e74ee84.
…d for conformity, relocated check for num images for exicution before allocation and image loading
This reverts commit dbe64d6.
… unsigned for conformity, relocated check for num images for exicution before allocation and image loading" This reverts commit ab6c7c7.
Added overflow protection in get_num_images function, redefined num_images to unsigned int in compress and decompress to match dump
…t exicution of allocation and strcpy if there are no images.
…lue for get_num_images
Contributor
Author
|
Accidentally deleted DWT.c thinking I was deleting the change. this pull request is to resolve a type conversion issue in the main function. The type for num_images in main is OPJ_INT32, return type of get_num_images is unsigned int. |
Contributor
Author
|
to be clear I reverted my branch to include DWT.c |
rouault
reviewed
Jan 16, 2022
…sues in opj_compress.c related to signed integer use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.