Support setting enumcs for CMYK and EYCC color space#1529
Merged
rouault merged 2 commits intouclouvain:masterfrom Jun 14, 2024
radarhere:cmyk
Merged
Support setting enumcs for CMYK and EYCC color space#1529rouault merged 2 commits intouclouvain:masterfrom radarhere:cmyk
rouault merged 2 commits intouclouvain:masterfrom
radarhere:cmyk
Conversation
rouault
reviewed
Jun 14, 2024
| jp2->enumcs = 17; /* greyscale */ | ||
| } else if (image->color_space == 3) { | ||
| jp2->enumcs = 18; /* YUV */ | ||
| } else if (image->color_space == 4) { |
Collaborator
There was a problem hiding this comment.
would you mind using the OPJ_CLRSPC_xxxx enumeration values (for those new entries as well as for the 3 above existing ones?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per
openjpeg/src/lib/openjp2/jp2.c
Lines 2874 to 2884 in 70e6263
adds CMYK and EYCC to
openjpeg/src/lib/openjp2/jp2.c
Lines 1992 to 1998 in 70e6263