Fixed ICC profile copy failure on write#1574
Merged
rouault merged 2 commits intouclouvain:masterfrom Feb 11, 2025
Merged
Conversation
Collaborator
|
@mircomir can you fix formatting issues ? See https://github.com/uclouvain/openjpeg/actions/runs/12952828902/job/36315685711?pr=1574 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I set a color profile in write I always get an assert in
opj_jp2_write_colr()(line 831). I've been using the library for a short time, but I didn't find any other way to pass the profile on write. Looking at the code it seems that the color profile set in the image is never copied tojp2->color.