Skip to content

Update allocation functions#636

Merged
mayeut merged 11 commits intomasterfrom
opj_malloc-625
Oct 18, 2015
Merged

Update allocation functions#636
mayeut merged 11 commits intomasterfrom
opj_malloc-625

Conversation

@mayeut
Copy link
Copy Markdown
Collaborator

@mayeut mayeut commented Oct 17, 2015

No description provided.

mayeut added a commit that referenced this pull request Oct 18, 2015
@mayeut
Merge pull request #636 from uclouvain/opj_malloc-625
05b3afd 
Update allocation functions
Fix #625 
Fix #624
Fix #635
@mayeut mayeut merged commit 05b3afd into master Oct 18, 2015
@mayeut mayeut deleted the opj_malloc-625 branch October 18, 2015 01:15
@malaterre
Copy link
Copy Markdown
Collaborator

malaterre commented Oct 19, 2015

@mayeut could you please add some more details on your behavior change for aligned_realloc ?

@mayeut
Copy link
Copy Markdown
Collaborator Author

mayeut commented Oct 19, 2015

@malaterre, not much to be said.
alignment wasn't check (needs to be power of 2)
a_ptr wasn't check either (if NULL, a crash would have happen)

The main thing is that the aligned_realloc is not used anymore (no need to, an aligned_free + aligned_malloc is all that's needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mayeut @malaterre @detonin