Add sanity check for tile coordinates#823
Merged
mayeut merged 2 commits intouclouvain:masterfrom Sep 7, 2016
Merged
Conversation
Coordinates are casted from OPJ_UINT32 to OPJ_INT32 Add sanity check for negative values and upper bound becoming lower than lower bound. See also https://pdfium.googlesource.com/pdfium/+/b6befb2ed2485a3805cddea86dc7574 510178ea9
Collaborator
Author
|
there was an error when referencing test data. |
mayeut
added a commit
to mayeut/openjpeg-data
that referenced
this pull request
Sep 8, 2016
Update uclouvain/openjpeg#826 Also renamed data for uclouvain/openjpeg#823 which was labelled after uclouvain/openjpeg#822
mayeut
added a commit
to mayeut/openjpeg
that referenced
this pull request
Sep 8, 2016
Update uclouvain#826 Also correct names for data of issue uclouvain#823
mayeut
added a commit
to uclouvain/openjpeg-data
that referenced
this pull request
Sep 8, 2016
Update uclouvain/openjpeg#826 Also renamed data for uclouvain/openjpeg#823 which was labelled after uclouvain/openjpeg#822
Merged
mayeut
added a commit
that referenced
this pull request
Sep 8, 2016
malaterre
pushed a commit
that referenced
this pull request
Sep 13, 2016
Coordinates are casted from OPJ_UINT32 to OPJ_INT32 Add sanity check for negative values and upper bound becoming lower than lower bound. See also https://pdfium.googlesource.com/pdfium/+/b6befb2ed2485a3805cddea86dc7574510178ea9
malaterre
pushed a commit
that referenced
this pull request
Sep 13, 2016
|
http://www.openwall.com/lists/oss-security/2016/09/08/8 indicates this issue was the same as CVE-2016-5157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinates are casted from OPJ_UINT32 to OPJ_INT32
Add sanity check for negative values and upper bound becoming lower
than lower bound.
See also
https://pdfium.googlesource.com/pdfium/+/b6befb2ed2485a3805cddea86dc7574510178ea9