Fix potential out-of-bounds read (coverity) #844
Merged
mayeut merged 2 commits intouclouvain:masterfrom Sep 21, 2016
Merged
Conversation
CID 1190207 (uclouvain#1 of 1): Out-of-bounds read (OVERRUN) Variable i must be checked before testing query_param.box_type. Signed-off-by: Stefan Weil <sw@weilnetz.de>
CID 1190206 (uclouvain#1 of 1): Out-of-bounds read (OVERRUN) Variable i must be checked before testing query_param.box_type. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Contributor
Author
|
The last update for Coverity Scan was more than two years ago. An update would be really helpful. |
Collaborator
|
@malaterre , you might wan't this in branch 2.1 for openjpip package |
Contributor
Author
I just noticed that there are two entries for OpenJPEG on Coverity Scan:
This is a little bit confusing. |
malaterre
pushed a commit
that referenced
this pull request
Sep 21, 2016
* query_parser: Fix potential out-of-bounds read (coverity) CID 1190207 (#1 of 1): Out-of-bounds read (OVERRUN) Variable i must be checked before testing query_param.box_type. Signed-off-by: Stefan Weil <sw@weilnetz.de> * jpip_parser: Fix potential out-of-bounds read (coverity) CID 1190206 (#1 of 1): Out-of-bounds read (OVERRUN) Variable i must be checked before testing query_param.box_type. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Collaborator
|
@stweil, the one used by travis-ci is uclouvain-openjpeg . I think there was some problem with the old one at some point. Maybe @detonin has more info about this. |
Contributor
|
@stweil yes there was a bug on coverity website preventing to link the legacy account with the github repo so we add to create a new one. I should probably close the old one and invite people on uclouvain-openjpeg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Weil sw@weilnetz.de