fix static build only against tiff and its indirect dependencies#866
fix static build only against tiff and its indirect dependencies#866rouault merged 1 commit intouclouvain:masterfrom
Conversation
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. This build issue [1] was triggered by the Buildroot farms. [1] http://autobuild.buildroot.net/results/d0d/d0d22727311d6300e0e400728126170407bfd699/build-end.log Signed-off-by: Samuel Martin <s.martin49@gmail.com>
This change adds a patch to openjpeg fixing the tiff indirect dependencies in case of static build. A similar patch for upstream master has been submitted [1]. Fixes: http://autobuild.buildroot.net/results/d0d/d0d22727311d6300e0e400728126170407bfd699/ and many others... [1] uclouvain/openjpeg#866 Signed-off-by: Samuel Martin <s.martin49@gmail.com> Cc: Olivier Schonken <olivier.schonken@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
|
@rouault do you have some comments on this PR? It would be great if could be merged so we could remove it from buildroot. |
|
I'm not a CMake expert, but I'm wondering what is the effect on this change on dynamic builds |
|
This change will not break dynamic builds, it has been applied in buildroot for more than 4 years now. You can find more information about pkg-config here: https://linux.die.net/man/1/pkg-config. Basically, with this change, the |
|
ok thanks for the explanations. let's merge this |
|
Thanks, if you could also merge #867, it would be perfect. If you have any issues related to these these pull requests, do not hesitate to ping me. |
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
This change allows to get all required CFLAGS/LDFLAGS in case of static only build. Fixes a buildroot build failure (see [1], [2] and [3]). [1] http://autobuild.buildroot.net/results/5ce/5cee20afd8bef5268832cddcb3a5270746be7a57 [2] http://lists.busybox.net/pipermail/buildroot/2016-November/177187.html [3] http://lists.busybox.net/pipermail/buildroot/2016-November/177188.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Depends on uclouvain#866
…atic libraries are not in system directories (fixes uclouvain#1430) Note that the fix might be partial only for static-only builds (cf comments) Ammends PR uclouvain#866 and uclouvain#867
No description provided.