Enhance bubble menu positioning for table cell selections #6482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b20c30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 71 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the bubble menu’s positioning logic for table cell selections in the editor. Key changes include introducing a new utility function to combine DOM rectangles, updating position calculations for cell selections in the BubbleMenuView, and a changeset file for versioning.
- Added combineDOMRects utility function to merge two DOMRect instances
- Updated updatePosition method in BubbleMenuView to account for multi-cell selections
- Created a changeset documenting the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/extension-bubble-menu/src/bubble-menu-plugin.ts | Introduced combineDOMRects and updated position logic |
| .changeset/early-guests-melt.md | Added changeset for bubble menu positioning fix |
Co-authored-by: Copilot <[email protected]>
…com:ueberdosis/tiptap into bdbch/6410-table-cell-bubblemenu-adjustment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
This pull request enhances the
BubbleMenuPlugininpackages/extension-bubble-menuby improving the handling of cell selections in the editor. It introduces a utility function to combine DOM rectangles and updates the logic for positioning the bubble menu when a cell selection is detected.Improvements to cell selection handling:
Added
combineDOMRectsutility function: This function calculates a bounding rectangle that encompasses two DOM rectangles, ensuring proper handling of multi-cell selections. (packages/extension-bubble-menu/src/bubble-menu-plugin.ts, packages/extension-bubble-menu/src/bubble-menu-plugin.tsR15-R44)Updated
updatePositionmethod inBubbleMenuView: Enhanced the logic to detect cell selections and compute the correct bounding rectangle for the bubble menu. This ensures that the menu is positioned correctly for both single-cell and multi-cell selections. (packages/extension-bubble-menu/src/bubble-menu-plugin.ts, packages/extension-bubble-menu/src/bubble-menu-plugin.tsL294-R349)Checklist
Related Issues
Fixes #6410