use changeset publish instead of manually publishing via pnpm #6490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the publishing process to use changeset publish instead of the manual pnpm publish command, ensuring that only packages with version bumps are published and streamlining the release process.
- Updated the publish script in package.json to use "pnpm changeset publish".
- Simplified the publishing step in .github/workflows/publish.yml by removing the conditional tag logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated the publish script to build and then use changeset publish. |
| .github/workflows/publish.yml | Removed conditional publish tag logic to simplify the workflow command. |
Comments suppressed due to low confidence (2)
package.json:26
- Ensure that the new publish behavior using 'changeset publish' and its pre tag configuration is documented clearly, so users are aware of the transition and required dependency adjustments.
"publish": "pnpm run build && pnpm changeset publish",
.github/workflows/publish.yml:71
- Consider including a clarification in the workflow documentation about the removal of the conditional tag logic to help users understand the change in release process.
publish: pnpm run publish
@tiptap/core
@tiptap/extension-blockquote
@tiptap/extension-bubble-menu
@tiptap/extension-bullet-list
@tiptap/extension-bold
@tiptap/extension-code
@tiptap/extension-code-block
@tiptap/extension-code-block-lowlight
@tiptap/extension-collaboration
@tiptap/extension-collaboration-caret
@tiptap/extension-details
@tiptap/extension-color
@tiptap/extension-document
@tiptap/extension-drag-handle
@tiptap/extension-drag-handle-react
@tiptap/extension-drag-handle-vue-2
@tiptap/extension-drag-handle-vue-3
@tiptap/extension-emoji
@tiptap/extension-file-handler
@tiptap/extension-floating-menu
@tiptap/extension-font-family
@tiptap/extension-hard-break
@tiptap/extension-highlight
@tiptap/extension-heading
@tiptap/extension-horizontal-rule
@tiptap/extension-image
@tiptap/extension-invisible-characters
@tiptap/extension-italic
@tiptap/extension-link
@tiptap/extension-mathematics
@tiptap/extension-list
@tiptap/extension-mention
@tiptap/extension-node-range
@tiptap/extension-ordered-list
@tiptap/extension-paragraph
@tiptap/extension-strike
@tiptap/extension-subscript
@tiptap/extension-superscript
@tiptap/extension-table
@tiptap/extension-text
@tiptap/extension-table-of-contents
@tiptap/extension-text-align
@tiptap/extension-text-style
@tiptap/extension-underline
@tiptap/extension-typography
@tiptap/extension-unique-id
@tiptap/extension-youtube
@tiptap/extensions
@tiptap/html
@tiptap/react
@tiptap/pm
@tiptap/starter-kit
@tiptap/static-renderer
@tiptap/suggestion
@tiptap/vue-2
@tiptap/extension-character-count
@tiptap/extension-dropcursor
@tiptap/vue-3
@tiptap/extension-focus
@tiptap/extension-gapcursor
@tiptap/extension-history
@tiptap/extension-list-item
@tiptap/extension-list-keymap
@tiptap/extension-placeholder
@tiptap/extension-table-cell
@tiptap/extension-table-header
@tiptap/extension-table-row
@tiptap/extension-task-list
@tiptap/extension-task-item
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the publish script so it uses
changeset publish. This only publishes packages that actually were version bumped (or were not published yet) - this helps us to only publish packages that need to be re-published & avoid CI failures.Important Note:
changeset publishwill always use thepretag defined for changesets so after this PR is merged, changes that were previously deployed on@nextwill now be deployed as@beta(which objectively will be better BUT will require Tiptap users to adjust their dependencies).AI Summary
Changes Overview
This pull request updates the publishing workflow and the
publishscript inpackage.jsonto improve consistency and streamline the release process. The most important changes involve replacing custom logic for determining the publish tag with simpler and more standardized commands.Workflow updates:
.github/workflows/publish.yml: Simplified thepublishcommand in thechangesets/actionstep by removing conditional logic for determining the tag (nextorlatest). The command now usespnpm run publishdirectly.Script updates:
package.json: Updated thepublishscript to usepnpm changeset publishinstead ofpnpm publish -r --no-git-checks, aligning it with the changesets workflow.Checklist