feat: convert to an Analyzer#22
Merged
Merged
Conversation
Contributor
|
@ldez Really admiring all the work you put into golangci! |
Contributor
|
@ldez thanks for the contribution. We appreciate the effort 🙏 Currently we are in a busy state, since the holidays are around the corner. I will review this PR and ask a peer to double check it. That said, this will likely happen next week. Thanks for being patient. Best regards and happy holidays (you too @martialblog). |
robinknaapen
approved these changes
Dec 16, 2024
Contributor
|
LGTM, I've asked a co-worker for a second review |
Contributor
|
Thanks for the contribution. Do you intend to create a PR on golangci-lint, or are we expected to do so? Kind regards |
Contributor
Author
|
Thank you for merging the PR, I handle the update inside golangci-lint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ease the integration inside golangci-lint, I converted the
Runfunction into an Analyzer.