Media Picker search no longer shows folders

[arknu]

Which Umbraco version are you using?

17.0.2

Bug summary

In v13 searching in the media picker also shows any matching folders, even though the picker is configured to not allow folders to be picked.

In v17, the search seems limited to only show those media items you can actually pick. No folders show up.

This breaks workflows for several of our clients who have large media libraries organized in many folders. They depend on being able to find the specific folder. In v13 this was no issue, but it no longer works in v17.

Specifics

No response

Steps to reproduce

Have some folders in the media library and a media picker configured to not pick folders.
Try searching for a folder in the media picker. It does not show up.

Expected result / actual result

I'd expect the folder to show up in the search results, as it did in v13, but not be selectable. You should of course be able to open the folder normally.

Instead, the folder does not show up.

[github-actions]

Hi there @arknu!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[arknu]

I just had a go at making a PR for this and it seems that on the latest main, behavior is already different and better: The media picker now appears to do no filtering on allowed types when searching. This fixes this issue. Can't find the commit where this was changed, though...

Can you confirm that this change will be included in 17.1? If so, I'd say this issue is fixed.

[AndyButland]

If it's in main now, it'll be in 17.1. So I'll mark this as closed and label it with that version.

[arknu]

@AndyButland I just installed nightly build 17.1.0--rc.preview.255.g044cd1d to test this. Shouldn't I be seeing this change? Also, the fix for #20407 does not seem to be there.

[AndyButland]

I would have expected so, but to be sure, you can check the 17.1.0-rc when it's out next Tuesday. I just built that today from a release branch taken from main.