GetLockoutEnd

[LvledPanic]

Which Umbraco version are you using?

v13.12.1

Bug summary

When a user has IsLockedOut = true, and lastLockoutDate = null, the code is returning DateTime.MaxValue as a DateTimeOffset. This seems to be adjusting a local DateTime to a UTC date time, and it is exceeding the max value.

        if (lockedOutUntil.HasValue is false)
        {
            return DateTime.MaxValue;
        }

ought to be returning DateTimeOffset.MaxValue

Specifics

No response

Steps to reproduce

A member needs to have IsLockedOut = true, and lastLockoutDate = null, and the local timezone needs to be a UTC -* timezone. (America/Detroit in this case)

Expected result / actual result

No response

[github-actions]

Hi there @LvledPanic!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

Thanks for reporting and diagnosing this @LvledPanic. I've addressed with the PR linked above.

[AndyButland]

Fixed via #21157 for 13.13.