Skip to content

Ensure SQLite connection strings adhere to recommendations #16627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rbottema
Copy link
Contributor

As per umbraco/UmbracoDocs#4649, the preferred cache mode is Private. This updates the templates and other usages to actually use the cache mode Umbraco recommends.

As per umbraco/UmbracoDocs#4649, the preferred cache mode is Private. This updates the templates and other usages to actually use the cache mode Umbraco recommends.
Copy link

github-actions bot commented Jun 19, 2024

Hi there @rbottema, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @rbottema thanks a lot for your PR, someone on the core collaborators team will review this soon 😄

@emmagarland emmagarland self-assigned this Aug 9, 2024
@emmagarland
Copy link
Contributor

Hi @rbottema

Thanks for this PR! Good catch re the documentation.

I've tested and it changes the connection string to Private as you say. However, the integration tests are now failing. I'm presuming this is to do with the change of connection string.

I merged the latest contrib into your branch to check again and the same thing happened, is this something you'd be able to double check or would you like me to reach out to HQ for some help?

Best regards

Emma

@nul800sebastiaan nul800sebastiaan changed the base branch from contrib to main May 5, 2025 12:24
@emmagarland emmagarland removed their assignment May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants