User invite email fails if visited more than once without completing

[dchallener]

#17681

This PR looks to reset the security stamp back to previous when doing the signin behind the scenes in the same way lastlogindate is being reset. This allows the action to happen again until the user completes the process.

[github-actions]

Hi there @dchallener, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[emmagarland]

Hi @dchallener ,

Thanks for your PR to implement #17681, and stop the user invite email failing if it is visited > once without completing.

One of the Core Collaborators team will review this as soon as possible - it also seems like one that we want HQ to review, so I'll contact them about it.

Best wishes

Emma

[dchallener]

Thanks @emmagarland ,

Let me know if there is anything else required in the meantime. Would be super great to get this into an upcoming release as is causing us issues with clients using mail scanners or link checkers.

Best wishes,
David

[emmagarland]

@dchallener thanks David, we're currently in discussion with HQ about this as it might be some surrounding code needs tweaking. I'll let you know as soon as we have a decision on the best approach!

[emmagarland]

@dchallener sorry for the delay, I have come back to discussing this with HQ so will endeavour to get this either merged or any tweaks recommended to you ASAP!

Emma

[emmagarland]

Have tested the following scenarios:

• Invite link can be used on first access
• Invite link can be used second access
• User can subsequently login and out

Approving

[emmagarland]

Hi @dchallener, thanks so much for your pull request to fix the issue "User invite fails if visited more than once without completing" #17681.

I've tested and the following scenarios work as expected:

• Invite link can be used on first access
• Invite link can be used second access
• User can subsequently login and out

It has now been successfully merged for the 13.9 release! 🙌 #h5yr

Best wishes

Emma