Fix root path regression for the Delivery API #19216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
approved these changes
May 3, 2025
There was a problem hiding this comment.
Good catch @kjac, thanks. I can confirm this fixes the issue from manual testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
#19063 has introduced a regression the Delivery API: It is no longer possible to fetch the route item by path (
/).This PR fixes it.
Additionally, #19063 introduced the new method
IsResolvablePath(string path)onIApiContentPathResolver, as part a fix for handling file requests correctly. But since this handling is not necessary for V15+ due to the changes in caching, the fix has not been forward merged - nor should it. For good measure I've added an obsoletion message to the method in this PR 👍