additional context name for 'content property context' #19375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
requested review from
Copilot and
madsrasmussen
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR renames and refactors the content property context to use the new "property type based property context," deprecating the old naming and exports. Key changes include:
- Removing old context exports from the main content index.
- Updating the property element to use the new context and renaming variables accordingly.
- Introducing new context token and context files with deprecation notices for the old tokens.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Umbraco.Web.UI.Client/src/packages/content/content/index.ts | Removed exports for the old content property context. |
| src/Umbraco.Web.UI.Client/src/packages/content/content/content-property.context-token.ts | Removed the old context token definition. |
| src/Umbraco.Web.UI.Client/src/packages/content/content/components/property-type-based-property/property-type-based-property.element.ts | Updated to use the new property type based context and renamed a variable. |
| src/Umbraco.Web.UI.Client/src/packages/content/content/components/property-type-based-property/property-type-based-property.context.ts | Renamed the context class and updated the super call with the new token; added a deprecation alias. |
| src/Umbraco.Web.UI.Client/src/packages/content/content/components/property-type-based-property/property-type-based-property.context-token.ts | Added new context token and deprecated the old token. |
| src/Umbraco.Web.UI.Client/src/packages/content/content/components/property-type-based-property/index.ts | Re-exported the updated context and token files. |
...tent/content/components/property-type-based-property/property-type-based-property.element.ts
Show resolved
Hide resolved
madsrasmussen
approved these changes
May 21, 2025
madsrasmussen
approved these changes
May 21, 2025
nielslyngsoe
deleted the
v16/hotfix/provide-content-property-context-under-a-new-name
branch
|
This change introduces a regression with Example usage in my Contentment package. This worked in 16-rc3, but doesn't the context doesn't resolve in 16-rc4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing 'content property context' under the name 'property type based property context'. keeping the old and marked that as deprecated, with removal in v.18.