Closing redirecting modals fix #19420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where modal URLs persist after closing, which prevented users from reusing the same URL. Key changes include:
- Adding and refining destroy methods to ensure proper cleanup.
- Adjusting modal redirect logic by implementing a timeout mechanism.
- Handling potential initialization failures in repository functions.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/packages/core/workspace/submittable/submittable-workspace-context-base.ts | Added an override destroy method to clean up component state. |
| src/packages/core/workspace/entity-detail/entity-detail-workspace-base.ts | Removed a duplicate call to set the "isNew" state. |
| src/packages/core/workspace/controllers/workspace-is-new-redirect.controller.ts | Introduced a timeout to delay redirect and updated the destroy method, although a duplicate super.destroy() call is present. |
| src/packages/core/router/router-slot/router-slot.ts | Added parent cleanup and improved redirection logic with an additional browser URL check. |
| src/packages/core/repository/item/item-repository.interface.ts | Updated the return type for the items method to allow undefined. |
| src/packages/core/repository/item/item-repository-base.ts | Wrapped initialization in a try-catch block, but an inconsistency in the return type was introduced. |
| src/packages/content/content/workspace/content-detail-workspace-base.ts | Removed a redundant setIsNew(false) call to ensure proper state management. |
...eb.UI.Client/src/packages/core/workspace/controllers/workspace-is-new-redirect.controller.ts
Outdated
Show resolved
Hide resolved
...eb.UI.Client/src/packages/core/workspace/controllers/workspace-is-new-redirect.controller.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/core/repository/item/item-repository-base.ts
Show resolved
Hide resolved
…ers/workspace-is-new-redirect.controller.ts Co-authored-by: Copilot <[email protected]>
…ers/workspace-is-new-redirect.controller.ts Co-authored-by: Copilot <[email protected]>
iOvergaard
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with creating Documents from a Collection, on a real server, where 2. 3. or 4. time ends up the the modal URL stay despite the modal closing. which prevents the user from navigating to that exact URL again.
Please carefully test various deep modals etc. complex URL situations.