Skip to content

V16-RC: Typings error with http client #19489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

iOvergaard
Copy link
Contributor

Description

This promotes @hey-api/client-fetch from devDependencies to dependencies because it is referenced on npm.

@Copilot Copilot AI review requested due to automatic review settings June 5, 2025 06:39
@iOvergaard iOvergaard requested a review from lauraneto June 5, 2025 06:39
@iOvergaard iOvergaard enabled auto-merge (rebase) June 5, 2025 06:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a typings error with the HTTP client by promoting "@hey-api/client-fetch" from devDependencies to dependencies so that it is correctly bundled on npm.

  • Moves "@hey-api/client-fetch" from devDependencies to dependencies
  • Fixes JSON formatting by adding the missing comma after "uuid"
Files not reviewed (1)
  • src/Umbraco.Web.UI.Client/package-lock.json: Language not supported

Copy link
Contributor

@lauraneto lauraneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error that I was seeing is gone now. Thanks! 🙌

@iOvergaard iOvergaard merged commit 8e71305 into release/16.0 Jun 5, 2025
24 checks passed
@iOvergaard iOvergaard deleted the v16/bugfix/heyapi-client-on-npm branch June 5, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants