Skip to content

Addresses issue #1402 - Possible to search and replace method/scenario names with new name. #1403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 26, 2022

Conversation

suratdas
Copy link
Contributor

If we want to change method or scenario name in tests, we can use this feature. This will also take care of existing parameters without impacting them. Please refer to below is example.

FitnesseReplaceWindow

FitnesseSerchReplace

@fhoeben
Copy link
Collaborator

fhoeben commented Dec 19, 2022

I don't believe it is presented to the user very clearly like this.

I believe it would be better to have two sections on this page: one for (the existing) regular search/replace and other (below it) to do method search and replace.
This will also allow the caveats regarding the method search/replace to be closer to the actual input boxes.

@suratdas
Copy link
Contributor Author

Thanks for the comment. I changed the UI based on your feedback. The new UI looks like below.
image

Copy link
Collaborator

@fhoeben fhoeben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor text changes.
Let's see whether we get user feedback whether this works good enough for the requestor.

suratdas and others added 4 commits December 25, 2022 12:25
Co-authored-by: Fried Hoeben <[email protected]>
Co-authored-by: Fried Hoeben <[email protected]>
Co-authored-by: Fried Hoeben <[email protected]>
Co-authored-by: Fried Hoeben <[email protected]>
@suratdas suratdas requested a review from fhoeben December 25, 2022 20:27
@fhoeben fhoeben merged commit 9994d29 into unclebob:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants