feat(ui): enhance typing screen with improved layout and real-time updates#143
Merged
unhappychoice merged 4 commits intomainfrom Sep 4, 2025
Merged
feat(ui): enhance typing screen with improved layout and real-time updates#143unhappychoice merged 4 commits intomainfrom
unhappychoice merged 4 commits intomainfrom
Conversation
- Update display periodically (every 100ms) even without keyboard input - Ensures elapsed time, WPM, CPM, and other metrics update in real-time - Applies to all typing screen methods: start_session, show, show_with_state 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace single outer border with individual section borders (Challenge, Code, Metrics, Progress) - Apply consistent blue-based color scheme with cyan/yellow/green accents - Move [ESC] Options to bottom-left corner without border for cleaner look - Add line numbers to code display using actual source file line numbers - Implement compact layout with proper padding and spacing - Support real-time display updates for better user experience 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 33.00% 32.76% -0.24%
==========================================
Files 83 83
Lines 9201 9268 +67
==========================================
Hits 3037 3037
- Misses 6164 6231 +67
🚀 New features to boost your workflow:
|
- Replace calculate_real_time_result method to use elapsed_time instead of start_time.elapsed() - Fix issue where CPM would decrease during pause periods - Use actual elapsed time (excluding paused duration) for accurate metrics - Ensure real-time display matches final results consistency 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove unused start_time parameter from display_challenge_with_info method - Update all call sites to remove start_time argument - Use scoring_engine.get_elapsed_time() directly for consistent timing - Clean up method signatures for better maintainability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
UI Layout Improvements
Line Numbers Feature
Real-time Updates & CPM Fix
Code Quality Improvements
Test plan
cargo test) - 160 testscargo check,cargo clippy)cargo fmt)🤖 Generated with Claude Code