fix: merge objects with Module type

[TheAlexLichter]

🔗 Linked issue

Resolves #119

❓ Type of change

• 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c7a9a4) 44.74% compared to head (3174b1b) 45.73%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   44.74%   45.73%   +0.99%     
==========================================
  Files           4        4              
  Lines         219      223       +4     
  Branches       33       35       +2     
==========================================
+ Hits           98      102       +4     
  Misses        119      119              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pi0]

I'm wondering if it is purely for Date merging fix, using instance of Date would be faster

[TheAlexLichter]

it isn't. See the linked issue. It also applies to Module (import via *)

[pi0]

Oh, I see! With this PR want to merge Module instances!

[pi0]

Checking, this logic currently basically bypasses entire L59 as iterator symbol does not exist in any of tested values (removing the line also all the tests pass). Wondering how we can cover it

[TheAlexLichter]

Oh, I see! With this PR want to merge Module instances!

yes indeed 👍🏻

[TheAlexLichter]

Checking, this logic currently basically bypasses entire L59 as iterator symbol does not exist in any of tested values (removing the line also all the tests pass). Wondering how we can cover it

Oh, I see 🤔 That's a bit tricky. I also wonder how to cover it then...

But - do we need to? Dates are correctly replaced (not merged) like that too

[pi0]

I have ported test suite of is-plain-object (see commits to main) and also merged in with this PR. Intrestingly we will be breaking two more tests at least (Math and native arguments will be wrongly detected as pure object)

[pi0]

Updated with a logic that precisely works for Module to reduce (more!) regression chances